fix: duplicated slices are lingering the filter panel after DDL reload #602
Conversation
R/FilterStates.R
Outdated
|
|
||
| # Each filter state_id can only have 1 active remove observer at the time | ||
| remove_id <- sprintf("remove_%s", state_id) | ||
| if (!is.null(private$observers[[remove_id]])) { |
There was a problem hiding this comment.
This shouldn't be here. If we have one instance of FilteredData and multiple srv_active (for each module), then it is removing observers from other tabs. For example when module_specific = FALSE and two modules use the same filter - it will be possible to remove filter from the last-rendered tab only.
There was a problem hiding this comment.
We still need to keep track of the observers that are created.
I removed the overwrite, but keeping any additional observers with remove_<state_id>_<count>
Any observer that has the state id on its name is removed on method call state_list_remove via
state$destroy_observers() # already
lapply(
Filter(function(x) grepl(state$get_state()$id, x, fixed = TRUE), names(private$observers)),
function(x) private$observers[[x]]$destroy()
)Ideally we would push the observer to the state$private$observers, but that is private and requires new API on <teal.slice>/R/FilterState.R
R/FilterStates.R
Outdated
| remove_id_prefix <- sprintf("remove_%s", state_id) | ||
| remove_id <- sprintf("%s_%s", remove_id_prefix, sum(grepl(remove_id_prefix, names(private$observers)))) | ||
| private$observers[[remove_id]] <- remove_observer |
There was a problem hiding this comment.
For sake of simplicity, you can also:
- move
FilterState$<private>$observerstoFilterState$<public>$observers - set this
remove_observeras an element ofFilterState$observersclass - then
state_list_removecan remain unchanged and will callstate$destroy_observers()
…ce@669_insertUI@main * origin/669_insertUI@main: [skip actions] Bump version to 0.5.1.9006 Removes 'plotly_relayout' warning from console (#601)
Pull Request
Companion of insightsengineering/teal#1275
Note: There's a similar solution that is cleaner. I'll push it on Monday
Changes description
remove observerson filter panelremove observerwhen clearing filter panel