verbatim popup with shiny validation or red error for disabled

[nikolas-burkoff]

This used to come about on the mmrm module until it was fixed

Simpler reprex:

library(teal.code)
library(teal.widgets)
library(shiny)

ui <- fluidPage(
  verbatim_popup_ui("pop", "Warnings")
)

server <- function(input, output, session) {


  disabled <- reactive({
    validate(need(FALSE, "This is a validation but it is being shown!"))
    FALSE
  })

  verbatim_popup_srv(
    "pop",
    title = "boo",
    verbatim_content = reactive("Hello"),
    disabled = disabled
  )
}

shinyApp(ui, server)

Also the case if disabled produces a red error?

[nikolas-burkoff]

Something like this might work: 😑

verbatim_popup_ui <- function(id, button_label, type = c("button", "link"), ...) {
  checkmate::assert_string(id)
  checkmate::assert_string(button_label)

  ui_function <- switch(match.arg(type),
    "button" = shiny::actionButton,
    "link" = shiny::actionLink,
    stop("Argument 'type' should be 'button' or 'link'")
  )

  ns <- shiny::NS(id)
  ui_args <- list(
    inputId = ns("button"),
    label = button_label
  )


  shiny::tagList(
    shiny::singleton(
      shiny::tags$head(shiny::includeScript(system.file("js/verbatim_popup.js", package = "teal.widgets")))
    ),
    do.call(ui_function, c(ui_args, list(...))),
    # this is dummy output - see the comment in srv
    shiny::uiOutput(ns("disable_controller"), inline = TRUE, style = "font-size:0px")
  )
}

[donyunardi]

I see the same behavior in QQ Plot under tm_g_distribution:

Looking at ?validate help info, it does say:

If you use validate() in a reactive(), validation failures will automatically propagate to outputs that use the reactive.

Hiding the message by setting the font-size to 0 definitely works.

[mhallal1]

@nikolas-burkoff I tested out with different options but it seems that setting the font size to 0 in the style is the only working solution for now.

[donyunardi]

Acceptance Criteria:

• Validation error should not appear in Show Warnings and Show R Code button (verbatim_popup_*).