Add landing popup argument in init and soft deprecate calling it as a normal module
#1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gogonzo
reviewed
Aug 1, 2024
Co-authored-by: Dawid Kałędkowski <6959016+gogonzo@users.noreply.github.com> Signed-off-by: Vedha Viyash <49812166+vedhav@users.noreply.github.com>
m7pr
reviewed
Aug 1, 2024
m7pr
reviewed
Aug 1, 2024
m7pr
reviewed
Aug 1, 2024
|
@vedhav I added my comments, but those are relevant if we want to support only the parameter approach. If we want to support both: parameter and the possibility to pass as module (even for the soft deprecation period) then my comments are not releveant |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
landing_popup_moduleinsidemodulesargument ofinitlanding_popupargument toinitto accept this module.TealAppDriverto accept this new argument.