Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tdata in tealdata@main #808

Closed
wants to merge 22 commits into from
Closed

Tdata in tealdata@main #808

wants to merge 22 commits into from

Conversation

mhallal1
Copy link
Collaborator

@mhallal1 mhallal1 commented Feb 24, 2023

related to insightsengineering/teal.data#121

-Updated module_Teal and module_nested_Tabs to accept tdata
-removed tdata into teal.data
-updated tests and docs

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2023

Unit Tests Summary

    1 files    12 suites   18s ⏱️
126 tests 125 ✔️ 0 💤 0  1 🔥
257 runs  256 ✔️ 0 💤 0  1 🔥

For more details on these errors, see this check.

Results for commit b5b0457.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2023

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
init 💔 $7.87$ $+1.42$ $0$ $0$ $0$ $0$
tdata 💀 $0.34$ $-0.34$ $-33$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
init 💔 $5.55$ $+1.02$ init_data_accepts_a_single_MultiAssayExperiment_object
tdata 💀 $0.01$ $-0.01$ get_code_returns_character_of_code_if_tdata_object_has_code
tdata 💀 $0.00$ $-0.00$ get_code_returns_empty_character_if_tdata_object_has_no_code
tdata 💀 $0.00$ $-0.00$ get_code_tdata_accepts_tdata
tdata 💀 $0.00$ $-0.00$ get_code_tdata_returns_character_code
tdata 💀 $0.02$ $-0.02$ get_code_tdata_throws_error_when_input_is_not_tdata
tdata 💀 $0.00$ $-0.00$ get_join_keys_returns_JoinKeys_object_if_it_exists_inside_tdata
tdata 💀 $0.01$ $-0.01$ get_join_keys_returns_NULL_if_no_JoinKeys_object_exists_inside_tdata
tdata 💀 $0.01$ $-0.01$ get_metadata_returns_NULL_if_dataset_doesn_t_exist
tdata 💀 $0.01$ $-0.01$ get_metadata_returns_NULL_if_no_metadata
tdata 💀 $0.01$ $-0.01$ get_metadata_returns_NULL_if_no_metadata_for_given_dataset
tdata 💀 $0.00$ $-0.00$ get_metadata_returns_metadata_for_given_dataset
tdata 💀 $0.01$ $-0.01$ new_tdata_accepts_character_and_reactive_characters_for_code_argument
tdata 💀 $0.07$ $-0.07$ new_tdata_accepts_reactive_and_not_reactive_MAE_and_data.frames
tdata 💀 $0.00$ $-0.00$ new_tdata_does_not_throw_error_with_valid_metadata
tdata 💀 $0.01$ $-0.01$ new_tdata_throws_error_if_code_is_not_character_or_reactive_character
tdata 💀 $0.01$ $-0.01$ new_tdata_throws_error_if_contents_of_data_list_are_not_of_correct_type
tdata 💀 $0.02$ $-0.02$ new_tdata_throws_error_if_data_is_not_a_list_with_unique_names
tdata 💀 $0.01$ $-0.01$ new_tdata_throws_error_if_join_keys_is_not_of_class_JoinKeys
tdata 💀 $0.02$ $-0.02$ new_tdata_throws_error_if_metadata_is_not_a_list_with_unique_names_a_subset_of_the_names_of_data
tdata 💀 $0.00$ $-0.00$ new_tdata_throws_no_error_if_join_keys_is_of_class_JoinKeys
tdata 💀 $0.10$ $-0.10$ tdata2env_returns_environment_containing_tdata_contents_
tdata 💀 $0.01$ $-0.01$ tdata2env_throws_error_if_argument_is_not_tdata

Results for commit 1a6467a

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  ------------------------------
R/dummy_functions.R                 74      61  17.57%   12-95
R/example_module.R                  18       9  50.00%   23-26, 29-33
R/get_rcode_utils.R                 52       2  96.15%   94, 99
R/get_rcode.R                      137      54  60.58%   74, 81, 86, 211-277
R/include_css_js.R                  24       0  100.00%
R/init.R                            22       2  90.91%   188-189
R/module_nested_tabs.R             165       7  95.76%   57, 97, 101-102, 137, 188, 240
R/module_tabs_with_filters.R        68       1  98.53%   162
R/module_teal_with_splash.R         33       2  93.94%   65, 77
R/module_teal.R                    111       5  95.50%   49, 52, 155-156, 181
R/modules_debugging.R               18      18  0.00%    37-56
R/modules.R                        101       8  92.08%   341-366
R/reporter_previewer_module.R       12       2  83.33%   18, 22
R/show_rcode_modal.R                20      20  0.00%    17-38
R/utils.R                           13       0  100.00%
R/validate_inputs.R                 32       0  100.00%
R/validations.R                     62      39  37.10%   107-368
R/zzz.R                             11       7  36.36%   3-14
TOTAL                              973     237  75.64%

Diff against main

Filename                  Stmts    Miss  Cover
----------------------  -------  ------  -------
R/module_nested_tabs.R       +4       0  +0.11%
TOTAL                        +4       0  -0.69%

Results for commit: 1a6467a

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Signed-off-by: Davide Garolini <dgarolini@gmail.com>
@Melkiades
Copy link

I think this needs to get in before becoming stale. I may work on this if it is still a thing to have @donyunardi

@mhallal1
Copy link
Collaborator Author

I think this needs to get in before becoming stale. I may work on this if it is still a thing to have @donyunardi

Plans might have changed meanwhile regarding tdata, @gogonzo can advice more on this.

@gogonzo gogonzo closed this Jul 13, 2023
@gogonzo gogonzo deleted the tdata_in_tealdata@main branch July 13, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants