Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct SERREAS derivation in ael03 #284

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Correct SERREAS derivation in ael03 #284

wants to merge 11 commits into from

Conversation

Melkiades
Copy link
Contributor

Fixes #269

@Melkiades Melkiades added the sme label Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

Unit Tests Summary

340 tests   206 ✅  1m 3s ⏱️
135 suites   88 💤
  1 files     46 ❌

For more details on these failures, see this check.

Results for commit 481df95.

♻️ This comment has been updated with latest results.

@shajoezhu shajoezhu assigned BFalquet and khatril and unassigned BFalquet Nov 18, 2024
@Melkiades
Merge branch 'main' into 269_correct_SERREAS_derivation@main
939749d 
Signed-off-by: Davide Garolini <davide.garolini@roche.com>
@Melkiades @pawelru
Update book/listings/adverse-events/ael03.qmd
db3c2f4 
Co-authored-by: Pawel Rucki <12943682+pawelru@users.noreply.github.com>
Signed-off-by: Davide Garolini <dgarolini@gmail.com>
edelarua
edelarua requested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few small suggestions, and can you please update the snapshot as well? Then it should be good to go!

book/listings/adverse-events/ael03.qmd Outdated Show resolved Hide resolved
book/listings/adverse-events/ael03.qmd Outdated Show resolved Hide resolved
book/listings/adverse-events/ael03.qmd Outdated Show resolved Hide resolved
Melkiades and others added 6 commits November 25, 2024 09:40
@Melkiades @edelarua
Update book/listings/adverse-events/ael03.qmd
e708d3a 
Co-authored-by: Emily de la Rua <59304861+edelarua@users.noreply.github.com>
Signed-off-by: Davide Garolini <dgarolini@gmail.com>
@Melkiades @edelarua
Update book/listings/adverse-events/ael03.qmd
072b28a 
Co-authored-by: Emily de la Rua <59304861+edelarua@users.noreply.github.com>
Signed-off-by: Davide Garolini <dgarolini@gmail.com>
@Melkiades @edelarua
Update book/listings/adverse-events/ael03.qmd
1682402 
Co-authored-by: Emily de la Rua <59304861+edelarua@users.noreply.github.com>
Signed-off-by: Davide Garolini <dgarolini@gmail.com>
@Melkiades
Merge branch 'main' into 269_correct_SERREAS_derivation@main
2c92894
@shajoezhu
Merge branch 'main' into 269_correct_SERREAS_derivation@main
24d2839
@shajoezhu
Merge branch 'main' into 269_correct_SERREAS_derivation@main
69e3806
@shajoezhu
Copy link
Contributor

hi @Melkiades , can you update the snapshot please. Thank you!

@shajoezhu
Copy link
Contributor

hey @Melkiades , can you take a look at this again? the topleft is now different?

@Melkiades
Copy link
Contributor Author

Melkiades commented Nov 27, 2024 •
edited
Loading

hey @Melkiades , can you take a look at this again? the topleft is now different?

Fix coming!!

@Melkiades Melkiades mentioned this pull request Nov 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelru pawelru pawelru left review comments

@edelarua edelarua edelarua requested changes

@khatril khatril Awaiting requested review from khatril

Requested changes must be addressed to merge this pull request.

Assignees

@khatril khatril

Labels
Request changes sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SERREAS derivation in AEL03 needs correction
6 participants
@Melkiades @shajoezhu @pawelru @edelarua @BFalquet @khatril