Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mini-css-extract-plugin failing when biuilding #473

Open
kmachado opened this issue Aug 13, 2018 · 2 comments
Open

mini-css-extract-plugin failing when biuilding #473

kmachado opened this issue Aug 13, 2018 · 2 comments

Comments

@kmachado
Copy link

hello, before all great job 👏

This issue is a:

  • Bug report

I just update to 0.23.0 recently and found nwb build-react-component --copy-files fails building with error: TypeError: Cannot destructure property createHash of 'undefined' or 'null'

I just rolled back to previous working version 0.21.x and everything working again 😃
this is an issue related to mini-css-extract-plugin failing for different webpack versions and reported on webpack-contrib/mini-css-extract-plugin

seems to be fixed updating webpack 😃

thanks again and hope this to be an easy one 😉
@insin
Copy link
Owner

insin commented Aug 13, 2018

Which version of webpack does npm ls --depth=0 show you?

The minimum required version for this plugin is 4.4 and nwb@0.23.0 is using webpack@4.16.5.

@benyitzhaki benyitzhaki mentioned this issue Aug 21, 2018
Open
daohoangson added a commit to daohoangson/js-tinhte-api that referenced this issue Sep 13, 2018
@daohoangson
Dependency version bumps:
8e994b5 
- next 6.1.1-canary.5
- nwb 0.23.0
- react-tree-walker 4.3.0
- stats-webpack-plugin 0.7.0
- webpack-bundle-analyzer 3.0.2

next@6.1.1-canary.5 is required because nwb  has been updated to webpack 4, causing these issues:

- webpack-contrib/mini-css-extract-plugin#69
- insin/nwb#473
- https://github.com/zeit/next.js/releases/tag/6.1.1-canary.3 is the first version with webpack 4 and 6.1.2 still uses webpack 3...
daohoangson added a commit to daohoangson/js-tinhte-api that referenced this issue Sep 13, 2018
@daohoangson
Version bump 20180913 (#8)
d1bf43a 
* Use Node.js LTS (8.12.0)

* Update standard 12.0.1

* Dependency version bumps:

- isomorphic-unfetch 2.1.1
- lodash 4.17.11
- react 16.5.0
- react-dom 16.5.0
- sanitize-html 1.19.0

* Dependency version bumps:

- next 6.1.1-canary.5
- nwb 0.23.0
- react-tree-walker 4.3.0
- stats-webpack-plugin 0.7.0
- webpack-bundle-analyzer 3.0.2

next@6.1.1-canary.5 is required because nwb  has been updated to webpack 4, causing these issues:

- webpack-contrib/mini-css-extract-plugin#69
- insin/nwb#473
- https://github.com/zeit/next.js/releases/tag/6.1.1-canary.3 is the first version with webpack 4 and 6.1.2 still uses webpack 3...
@patrickmcelwee
Copy link

I am still getting this issue with nwb v0.23.0, because it seems the mini-css-extract-plugin is still not working on 4.16: webpack-contrib/mini-css-extract-plugin#69 (comment)

I think releasing a version with the latest version of webpack is the way to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@insin @patrickmcelwee @kmachado