Don't fail building when there is .babelrc file. #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, use .babelrc.build for the temporary config. Babel CLI v7 allows for --config-file option with which you can specify your own config file. Thanks to that, if there is already .babelrc file in the repo, the build can still continue instead of being stopped. ref: https://babeljs.io/docs/en/babel-cli#custom-config-path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, use .babelrc.build for the temporary config.
Babel CLI v7 allows for --config-file option with which you can specify
your own config file. Thanks to that, if there is already .babelrc file
in the repo, the build can still continue instead of being stopped.
ref: https://babeljs.io/docs/en/babel-cli#custom-config-path
Using babel configuration in nwb.config.js does not pass the specified presets/plugins etc to the demo server.
Note: opened against
masterbecause it is ahead of thenextbranch.