-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DHCPv6: Rename Option constants to CamelCase #106
DHCPv6: Rename Option constants to CamelCase #106
Conversation
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
=======================================
Coverage 61.68% 61.68%
=======================================
Files 68 68
Lines 3064 3064
=======================================
Hits 1890 1890
Misses 1068 1068
Partials 106 106
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I went through option_types.go and it also looks good
and despite the coverage didn't change, this isn't letting me merge the PR :( |
Ah I see - there are merge conflicts. @get9 can you look at that? I think that is caused by another PR that I merged |
To appease linters
80308a8
to
7319b8f
Compare
Fixed merge conflict |
Thanks! |
To appease linters. All changes were made using global find + replace, but I recommend looking over option_types.go to see all new option names.