Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DHCPv6: Rename Option constants to CamelCase #106

Merged
merged 1 commit into from
Jul 31, 2018

Conversation

get9
Copy link
Collaborator

@get9 get9 commented Jul 30, 2018

To appease linters. All changes were made using global find + replace, but I recommend looking over option_types.go to see all new option names.

@codecov
Copy link

codecov bot commented Jul 30, 2018

Codecov Report

Merging #106 into master will not change coverage.
The diff coverage is 55.4%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   61.68%   61.68%           
=======================================
  Files          68       68           
  Lines        3064     3064           
=======================================
  Hits         1890     1890           
  Misses       1068     1068           
  Partials      106      106
Impacted Files Coverage Δ
dhcpv6/modifiers.go 30.3% <0%> (ø) ⬆️
dhcpv6/option_nii.go 0% <0%> (ø) ⬆️
dhcpv6/option_prefixdelegation.go 0% <0%> (ø) ⬆️
dhcpv6/dhcpv6relay.go 60% <100%> (ø) ⬆️
dhcpv6/option_serverid.go 71.42% <100%> (ø) ⬆️
dhcpv6/option_userclass.go 75.67% <100%> (ø) ⬆️
dhcpv6/option_clientid.go 71.42% <100%> (ø) ⬆️
dhcpv6/option_statuscode.go 72.72% <100%> (ø) ⬆️
dhcpv6/option_elapsedtime.go 88.88% <100%> (ø) ⬆️
dhcpv6/option_relaymsg.go 82.6% <100%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6894ea...7319b8f. Read the comment docs.

insomniacslk
insomniacslk previously approved these changes Jul 31, 2018
Copy link
Owner

@insomniacslk insomniacslk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I went through option_types.go and it also looks good

@insomniacslk
Copy link
Owner

and despite the coverage didn't change, this isn't letting me merge the PR :(

@insomniacslk
Copy link
Owner

Ah I see - there are merge conflicts. @get9 can you look at that? I think that is caused by another PR that I merged

@get9
Copy link
Collaborator Author

get9 commented Jul 31, 2018

Fixed merge conflict

@insomniacslk insomniacslk merged commit bcf643b into insomniacslk:master Jul 31, 2018
@insomniacslk
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants