Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added osx to continuous integration #230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

insomniacslk
Copy link
Owner

As discussed in #229 we need to test on all the OSes we support

pmazzini
pmazzini previously approved these changes Jan 17, 2019
@insomniacslk
Copy link
Owner Author

I will also commit the fix for FreeBSD and OSX in this PR so I won't merge until then

@get9
Copy link
Collaborator

get9 commented Feb 11, 2019

Seems okay, still need those *BSD fixes though :)

@insomniacslk
Copy link
Owner Author

Seems okay, still need those *BSD fixes though :)

yeah, we didn't have time to work on it yet :( this PR won't be merged until the darwin build is fixed

@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #230 into master will increase coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   73.25%   74.39%   +1.13%     
==========================================
  Files          75       69       -6     
  Lines        3717     3116     -601     
==========================================
- Hits         2723     2318     -405     
+ Misses        862      703     -159     
+ Partials      132       95      -37
Impacted Files Coverage Δ
netboot/netconf.go 55.35% <0%> (-12.42%) ⬇️
dhcpv6/modifiers.go 62.29% <0%> (-8.72%) ⬇️
dhcpv6/dhcpv6message.go 51.94% <0%> (-6.02%) ⬇️
dhcpv4/dhcpv4.go 79.66% <0%> (-0.66%) ⬇️
dhcpv4/modifiers.go 88.23% <0%> (-0.34%) ⬇️
dhcpv4/option_ip_address_lease_time.go 100% <0%> (ø) ⬆️
dhcpv4/ztpv4/parse_circuitid.go 87.87% <0%> (ø) ⬆️
netboot/netboot.go 0% <0%> (ø) ⬆️
dhcpv4/nclient4/client.go
dhcpv4/nclient4/conn_linux.go
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc1a534...dc25849. Read the comment docs.

Signed-off-by: Andrea Barberio <insomniac@slackware.it>
@insomniacslk
Copy link
Owner Author

rebased

@pmazzini
Copy link
Collaborator

I think BSD was fixed but now we switched to Github CI. Do you want to update this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants