Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[interfaces] darwin #423

Merged
merged 4 commits into from
Aug 9, 2021
Merged

[interfaces] darwin #423

merged 4 commits into from
Aug 9, 2021

Conversation

pmazzini
Copy link
Collaborator

Fixes #378

@codecov
Copy link

codecov bot commented Apr 25, 2021

Codecov Report

Merging #423 (737e322) into master (427d11c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #423   +/-   ##
=======================================
  Coverage   67.36%   67.36%           
=======================================
  Files          88       88           
  Lines        3659     3659           
=======================================
  Hits         2465     2465           
  Misses       1030     1030           
  Partials      164      164           
Flag Coverage Δ
integtests ∅ <ø> (∅)
unittests 67.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 427d11c...737e322. Read the comment docs.

@pmazzini pmazzini force-pushed the macos branch 2 times, most recently from 2eae0c3 to 5fe4f18 Compare April 25, 2021 15:29
@insomniacslk
Copy link
Owner

The branch needs to be update. Otherwise looks good to me

@pmazzini pmazzini merged commit d4b282f into insomniacslk:master Aug 9, 2021
@pmazzini pmazzini deleted the macos branch August 9, 2021 19:22
@insomniacslk
Copy link
Owner

Screenshot_20210809-212203

Huh

@pmazzini
Copy link
Collaborator Author

pmazzini commented Aug 9, 2021

Did I break something?

@nadoo
Copy link

nadoo commented Aug 10, 2021

@pmazzini can't build for freebsd after this commit.

GOOS=freebsd GOARCH=amd64 go build

bindtodevice_bsd.go:8:2: imported and not used: "golang.org/x/sys/unix"
bindtodevice_bsd.go:18:9: undefined: syscall

@pmazzini pmazzini mentioned this pull request Aug 10, 2021
@pmazzini
Copy link
Collaborator Author

can't build for freebsd after this commit.

Sorry, #438 should fix it.

@pmazzini pmazzini mentioned this pull request Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Binding to an interface on MacOS does not function correctly
3 participants