Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: bump uio dep to move to unified native endian package #484

Merged
merged 1 commit into from
Dec 15, 2022
Merged

go.mod: bump uio dep to move to unified native endian package #484

merged 1 commit into from
Dec 15, 2022

Conversation

bradfitz
Copy link
Contributor

To pick up this change:
u-root/uio@c353755

Updates golang/go#57237

@bradfitz
Copy link
Contributor Author

cc @hugelgupf

@bradfitz bradfitz mentioned this pull request Dec 13, 2022
Closed
hugelgupf
hugelgupf previously approved these changes Dec 14, 2022
View reviewed changes
@hugelgupf
Copy link
Collaborator

I... don't know why the DCO check isn't doing anything. (But I don't have admin here so I can't override.) Could you push an empty commit or something to retrigger @bradfitz ?

@pmazzini pmazzini closed this Dec 14, 2022
@pmazzini pmazzini reopened this Dec 14, 2022
@codecov
Copy link

codecov bot commented Dec 14, 2022 •
edited
Loading

Codecov Report

Base: 67.53% // Head: 67.53% // No change to project coverage 👍

Coverage data is based on head (792548e) compared to base (f26e6d7).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #484   +/-   ##
=======================================
  Coverage   67.53%   67.53%           
=======================================
  Files          90       90           
  Lines        3801     3801           
=======================================
  Hits         2567     2567           
  Misses       1055     1055           
  Partials      179      179
Flag Coverage Δ
integtests ∅ <ø> (∅)
unittests 67.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bradfitz
go.mod: bump uio dep to move to unified native endian package
792548e 
To pick up this change:
u-root/uio@c353755

Updates golang/go#57237

Signed-off-by: Brad Fitzpatrick <brad@danga.com>
@bradfitz
Copy link
Contributor Author

bradfitz commented Dec 14, 2022 •
edited
Loading

@hugelgupf, okay, re-pushed

@bradfitz bradfitz requested a review from hugelgupf December 14, 2022 22:30
@bradfitz
Copy link
Contributor Author

DCO seems happy now. I also had never seen DCO bot get stuck like that before.

@bradfitz
Copy link
Contributor Author

@hugelgupf, whoops, you'd approved but then I clicked the "re-request approval" button out of habit.

@hugelgupf hugelgupf merged commit de60144 into insomniacslk:master Dec 15, 2022
bradfitz added a commit to tailscale/tailscale that referenced this pull request Dec 15, 2022
@bradfitz
go.bump: bump dhcp dep to remove another endian package from our tree
44af510 
To pull in insomniacslk/dhcp#484 to pull in u-root/uio#8

Updates golang/go#57237

Change-Id: I1e56656e0dc9ec0b870f799fe3bc18b3caac1ee4
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
@bradfitz bradfitz mentioned this pull request Dec 15, 2022
Merged
bradfitz added a commit to tailscale/tailscale that referenced this pull request Dec 15, 2022
@bradfitz
go.mod: bump dhcp dep to remove another endian package from our tree
ca7596d 
To pull in insomniacslk/dhcp#484 to pull in u-root/uio#8

Updates golang/go#57237

Change-Id: I1e56656e0dc9ec0b870f799fe3bc18b3caac1ee4
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz added a commit to tailscale/tailscale that referenced this pull request Dec 15, 2022
@bradfitz
go.mod: bump dhcp dep to remove another endian package from our tree
c02ccf6 
To pull in insomniacslk/dhcp#484 to pull in u-root/uio#8

Updates golang/go#57237

Change-Id: I1e56656e0dc9ec0b870f799fe3bc18b3caac1ee4
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
coadler pushed a commit to coder/tailscale that referenced this pull request Feb 2, 2023
@bradfitz @coadler
go.mod: bump dhcp dep to remove another endian package from our tree
e87ba87 
To pull in insomniacslk/dhcp#484 to pull in u-root/uio#8

Updates golang/go#57237

Change-Id: I1e56656e0dc9ec0b870f799fe3bc18b3caac1ee4
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugelgupf hugelgupf hugelgupf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bradfitz @hugelgupf @pmazzini