Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os instead of ioutil #502

Merged
merged 1 commit into from
Sep 6, 2023
Merged

os instead of ioutil #502

merged 1 commit into from
Sep 6, 2023

Conversation

pmazzini
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (01274d6) 72.77% compared to head (cb25548) 72.77%.

❗ Current head cb25548 differs from pull request most recent head 4ef8a41. Consider uploading reports for the commit 4ef8a41 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #502   +/-   ##
=======================================
  Coverage   72.77%   72.77%           
=======================================
  Files          91       91           
  Lines        5777     5777           
=======================================
  Hits         4204     4204           
  Misses       1398     1398           
  Partials      175      175           
Files Changed Coverage Δ
netboot/netconf.go 48.23% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@insomniacslk
Copy link
Owner

This looks good to me. Can you just squash the 6 commits into 1 before merging?

@pmazzini
Copy link
Collaborator Author

pmazzini commented Sep 5, 2023

Can you just squash the 6 commits into 1 before merging?

Should be done.

@insomniacslk insomniacslk merged commit c71a6be into insomniacslk:master Sep 6, 2023
8 checks passed
@pmazzini pmazzini deleted the ioutil branch September 7, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants