Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict padding setting to the nclient4 #545

Closed

Conversation

Bogdan-Denisenko
Copy link
Contributor

RFC 2132 says:
The end option marks the end of valid information in the vendor field. Subsequent octets should be filled with pad options.

But it seems that this does not mean that the client should consider packages with non-pad options after the End option invalid, because RFC 2119 explains:
3. SHOULD This word, or the adjective "RECOMMENDED", mean that there may exist valid reasons in particular circumstances to ignore a particular item, but the full implications must be understood and carefully weighed before choosing a different course.

This PR is an alternative to #543, with zero padding checking disabled by default.

Signed-off-by: Bogdan-Denisenko <bogdandenisenko28@gmail.com>
@Bogdan-Denisenko
Copy link
Contributor Author

@pmazzini review required

@pmazzini
Copy link
Collaborator

What would be the problem of not having a strictPadding option?

@Bogdan-Denisenko
Copy link
Contributor Author

What would be the problem of not having a strictPadding option?

I don't really know in what case this option might be useful. Do you think it's better to just remove the zero padding check without the option to enable it?

@soumiksamanta
Copy link

I am too blocked on this. We wanted to move from ISC DHCP to our own targeted implementation of DHCP. Waiting for this to get merged to master. This would be really helpful.

@hugelgupf
Copy link
Collaborator

hugelgupf commented Aug 25, 2024 via email

@Bogdan-Denisenko
Copy link
Contributor Author

Let’s try just removing the check. If it breaks someone, we can have the option later.

On Sun, Aug 25, 2024 at 22:05 Soumik Samanta @.> wrote: I am too blocked on this. We wanted to move from ISC DHCP to our own targeted implementation of DHCP. Waiting for this to get merged to master. This would be really helpful. — Reply to this email directly, view it on GitHub <#545 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPG3ETZDPHBRWG4APC6EMLZTI2JZAVCNFSM6AAAAABMADFLOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBYHE3TMMBRGQ . You are receiving this because you are subscribed to this thread.Message ID: @.>

Opened PR with removed zero padding check - #546.

@pmazzini
Copy link
Collaborator

Continuation in #546

@pmazzini pmazzini closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants