Resource updates #971
Draft
Resource updates #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
✅ Deploy Preview for inspec-aws canceled.
|
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
4 tasks
sa-progress
reviewed
Jun 27, 2023
| @@ -10,6 +10,9 @@ gem 'bundle' | |||
| # Note if the gem required is commented out, please raise a PR against the train-aws repo first | |||
| # In the mean time the gem can be added here for local development | |||
|
|
|||
| # TODO: remove when https://github.com/inspec/train-aws/pull/457 is merged | |||
| gem 'aws-sdk-account', '~> 1.14' | |||
There was a problem hiding this comment.
inspec/train-aws#457 is merged.Please update Gemfile.
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
…variable + made the ever/never funcs use ||= Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Signed-off-by: Aaron Lippold <lippold@gmail.com>
Signed-off-by: Aaron Lippold <lippold@gmail.com>
* updated and fixed the aws_accounts.rb resources to use standard styles and filterTable * Linted with 'cookstyle -A libraries/*.rb' * renamed the 'aws_account' resource to: - aws_primary_contact - aws_billing_contact - aws_operations_contact - aws_security_contact Signed-off-by: Aaron Lippold <lippold@gmail.com>
…ot configured Signed-off-by: Aaron Lippold <lippold@gmail.com>
Signed-off-by: Aaron Lippold <lippold@gmail.com>
* removed unneeded if clause in init method given fix Signed-off-by: Aaron Lippold <lippold@gmail.com>
Signed-off-by: Aaron Lippold <lippold@gmail.com>
|
This PR can be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe what this change achieves. Ensure you have read the Contributing to InSpec AWS document before submitting.
Issues Resolved
List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant
Check List
Please fill box or appropriate ([x]) or mark N/A.
rake lintpasses