Resource creation guide, edited #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mmclane <m.mclane@criteo.com>
Signed-off-by: Trevor Bramble <tbramble@chef.io>
dmccown
reviewed
Sep 17, 2018
docs/resource_creation_guide.md
Outdated
| The singular resource (`azurerm_subnet`) is used to test a specific resource of that type and should include all of the properties available. A plural resource (`azurerm_subnets`) is used to test the collection of resources of that type. This allows for tests to be written based on the group of resources. | ||
|
|
||
| ## Update libraries/support/azure/management.rb | ||
| The files in `libraries/support/azure` define how things are downloaded by the API. A definition needs to be added for the types of resources your going to be testing for (i.e. virtual machine, virtual networks, subnets, etc). This definition will need to include the location of the resource in the API. This is essentially the type of object. The [Azure Resource Explorer](https://resources.azure.com) can be used to determine the location by browsing for an object and referencing the object type. |
There was a problem hiding this comment.
s/resources your going/resources you're going/
docs/resource_creation_guide.md
Outdated
| ``` | ||
| def initialize(resource_group: nil, name: nil) | ||
| resp = client.subnet(resource_group, name) | ||
| return if resp.nil? || resp.key?('error') |
There was a problem hiding this comment.
We should use favor using this method: https://github.com/inspec/inspec-azure/blob/master/libraries/azurerm_resource.rb#L41
There was a problem hiding this comment.
That should also be added to the style guide.
Signed-off-by: Trevor Bramble <tbramble@chef.io>
dmccown
approved these changes
Oct 4, 2018
TrevorBramble
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces #129. Same great nutritional value, bold new flavor.