Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds name & desc to base class to conform to inspec check #208

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Adds name & desc to base class to conform to inspec check #208

merged 1 commit into from
Oct 14, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 14, 2019

Signed-off-by: Ruairi Fennell rfennell@chef.io

Description

inspec check requires all resources to have a name field set, otherwise NoMethodError is thrown at https://github.com/inspec/inspec/blob/master/lib/inspec/plugin/v1/plugin_types/resource.rb#L34

Check List

Adds name & desc to base class to conform to inspec check
06566f1 
Signed-off-by: Ruairi Fennell <rfennell@chef.io>
@ghost ghost self-requested a review October 14, 2019 09:58
skpaterson
skpaterson approved these changes Oct 14, 2019
View reviewed changes
Copy link

@skpaterson skpaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @r-fennell !

@skpaterson skpaterson merged commit 357990e into master Oct 14, 2019
@skpaterson skpaterson deleted the azure_resource_base_update branch October 14, 2019 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skpaterson