Bump Inspec, Adds Azurerm Disks Plural resource #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 30, 2019 17:30
…es magic number id splitting Signed-off-by: Ruairi Fennell <rfennell@chef.io>
ghost
self-requested a review
ghost
added
the
Version: Bump Minor
ghost
commented
Oct 30, 2019
| @@ -36,7 +37,7 @@ def to_s | |||
| def with_resource_group | |||
| lambda do |group| | |||
| # Get resource group from ID string | |||
| name = group.id.split('/')[4] | |||
| name = id_to_h(group.id)[:resource_group] | |||
Signed-off-by: Ruairi Fennell <rfennell@chef.io>
added 2 commits
November 5, 2019 16:05
Signed-off-by: Ruairi Fennell <rfennell@chef.io>
Signed-off-by: Ruairi Fennell <rfennell@chef.io>
skpaterson
approved these changes
Nov 5, 2019
…pec-azure into bump-inspec-add-disks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruairi Fennell rfennell@chef.io
Description
inspec-bingem.azurerm_virtual_machine_disksplural resource w/ tests, docs, etc.to_hconversion to baseazurerm_resourceclass to remove growing number of 'magic number' string manipulations (see example).Check List
rake lintpasses