Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmodb follow up #230

Merged
merged 2 commits into from
Jan 29, 2020
Merged

cosmodb follow up #230

merged 2 commits into from
Jan 29, 2020

Conversation

rmoles
Copy link
Contributor

@rmoles rmoles commented Jan 29, 2020

This is a follow-up PR to #175

Add outputs that can be used as attributes in the Integration tests.
Update terraform to resolve deprecation warnings.
Remove example-attributes.yml as this is covered by the addition of outputs.
Add log_profile creation with a comment explaining potential issues.

Signed-off-by: Ross Moles rmoles@chef.io

…pdate terraform to resolve deprecation warnings. Remove example-attributes.yml as this is covered by the addition of outputs. Add log_profile creation with a comment explaining potential issues.

Signed-off-by: Ross Moles <rmoles@chef.io>
@rmoles rmoles requested a review from a team January 29, 2020 15:25
@skpaterson skpaterson added the Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. label Jan 29, 2020
Signed-off-by: Ross Moles <rmoles@chef.io>
Copy link

@skpaterson skpaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks @rmoles

@rmoles rmoles requested review from skpaterson and a team January 29, 2020 15:32
@skpaterson skpaterson merged commit beaebd3 into master Jan 29, 2020
@chef-expeditor chef-expeditor bot deleted the cosmodb branch January 29, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants