Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README guide to reflect current Azure UI #241

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Conversation

Schwad
Copy link

@Schwad Schwad commented Apr 20, 2020

Description

Going through the step by step guide today as I configured Azure on my machine. These are two very minor changes to ensure our copy is flush with the copy currently being used on the Azure portal for future users.

@Schwad Schwad requested review from a team and james-stocks April 20, 2020 13:49
Copy link
Contributor

@rmoles rmoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Schwad. It can be a bit of a moving target at times with Azure.

@Schwad
Copy link
Author

Schwad commented Apr 24, 2020

@rmoles no problem.

Looks like I forgot the DCO as well 😆 , will sort that out today 👍

Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
@Schwad
Copy link
Author

Schwad commented Apr 30, 2020

Alright, I got the commit signed off, hopefully this should be fine to merge :)

I don't know what the merging protocol is on inspec-azure, but if you want to merge that's great otherwise I'm more than happy to with your approval once build passes 👍

@rmoles rmoles merged commit c3eac6f into master Apr 30, 2020
@rmoles rmoles deleted the Schwad-patch-1 branch April 30, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants