Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for querying HDInsight cluster #263

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

tboloo
Copy link

@tboloo tboloo commented Jul 13, 2020

Signed-off-by: Bolesław Tekielski boleslaw.tekielski@fisglobal.com

Description

Added support for querying HDInsight cluster

Issues Resolved

n/a

Check List

@tboloo tboloo requested a review from a team July 13, 2020 14:21
@rmoles
Copy link
Contributor

rmoles commented Jul 14, 2020

Hi @tboloo, thanks for raising this PR.
We have merged #264 which should resolve the failing build on this PR. If you would be able to rebase your branch, we should be able to get the CI build passing and this PR merged.

@tboloo tboloo force-pushed the feature/hdinsight_cluster branch from addfb94 to a247096 Compare July 15, 2020 05:06
Copy link
Contributor

@rmoles rmoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the submissions @tboloo. It would be great if you could add some documentation for this resource similar to this: https://github.com/inspec/inspec-azure/blob/master/docs/resources/azurerm_ad_user.md

Signed-off-by: Bolesław Tekielski <bolek@zeepeetek.pl>
@tboloo tboloo force-pushed the feature/hdinsight_cluster branch from a247096 to d26a466 Compare July 15, 2020 09:47
@tboloo tboloo requested a review from rmoles July 15, 2020 09:53
Copy link
Contributor

@rmoles rmoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thanks for your work on this @tboloo!

Copy link
Contributor

@omerdemirok omerdemirok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tboloo.
This looks good to me.

@rmoles rmoles merged commit 81c5d75 into inspec:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants