Added support for querying public IP address #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerdemirok
suggested changes
Jul 24, 2020
There was a problem hiding this comment.
Thanks for your valuable contribution @tboloo! 👏
Can you
- add a terraform resource into the
azure.tfand pick a random name for it? Random name is important to prevent name clashing at integration tests. - add the
ap_address_nameinto outputs.tf with the value of the terraform public ip resource name.
tboloo
force-pushed
the
feature/azurem_public_ip
branch
2 times, most recently
from
58ee1f6 to
62f3962
Compare
omerdemirok
suggested changes
Jul 27, 2020
There was a problem hiding this comment.
@tboloo
Thanks for the updates.
Let's fix the typo and set the terraform resource count default to 1.
terraform/outputs.tf
Outdated
| @@ -314,4 +314,9 @@ output "application_gateway_name" { | |||
| output "hdinsight_cluster_name" { | |||
| description = "HDINSIGHT cluster name." | |||
| value = var.hd_insight_count > 0 ? azurerm_hdinsight_interactive_query_cluster.hdinsight_cluster.0.name : "" | |||
| } | |||
|
|
|||
| output "ap_address_name" { | |||
There was a problem hiding this comment.
This should be ip_address_name.
Signed-off-by: Bolesław Tekielski <bolek@zeepeetek.pl>
tboloo
force-pushed
the
feature/azurem_public_ip
branch
from
62f3962 to
1123775
Compare
omerdemirok
approved these changes
Jul 27, 2020
skpaterson
added
the
Version: Bump Minor
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bolesław Tekielski bolek@zeepeetek.pl
Description
Added support for querying public IP address.
Issues Resolved
n/a
Check List
rake lintpasses