Re-write 11 static resources with the new backend #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Omer Demirok <odemirok@chef.io>
omerdemirok
added
the
Version: Bump Minor
added 2 commits
September 3, 2020 10:58
…esponse is empty Signed-off-by: Omer Demirok <odemirok@chef.io>
Signed-off-by: Omer Demirok <odemirok@chef.io>
rmoles
reviewed
Sep 4, 2020
docs/resources/azure_iothub.md
Outdated
|
|
||
| ## Syntax | ||
|
|
||
| The `resource_group` and `name` must be given as a parameter. |
There was a problem hiding this comment.
This isn't strictly true based on the Parameters explanation. They could also just provide the resource_id right?
There was a problem hiding this comment.
Would this explain this?
The `resource_group` and `name` or the `resource_id` must be given as a parameter.
rmoles
reviewed
Sep 4, 2020
|
|
||
| ## Syntax | ||
|
|
||
| The `resource_group`, `resource_name`, `event_hub_endpoint` and `name` must be given as a parameter. |
There was a problem hiding this comment.
Same as the previous comment
rmoles
reviewed
Sep 4, 2020
|
|
||
| ## Syntax | ||
|
|
||
| The `resource_group` and `name` must be given as a parameter. |
rmoles
reviewed
Sep 4, 2020
|
|
||
| ## Syntax | ||
|
|
||
| The `resource_group`, `server_name` and `name` must be given as a parameter. |
rmoles
reviewed
Sep 4, 2020
rmoles
reviewed
Sep 4, 2020
rmoles
reviewed
Sep 4, 2020
| name 'azure_storage_account_blob_container' | ||
| desc 'Verifies settings for a Azure Storage Account Blob Container' | ||
| example <<-EXAMPLE | ||
| describe azure_storage_account_blob_container(resource_group: 'rg', |
There was a problem hiding this comment.
(optional) Might be nice to make this a single line
added 2 commits
September 4, 2020 15:21
Signed-off-by: Omer Demirok <odemirok@chef.io>
Signed-off-by: Omer Demirok <odemirok@chef.io>
rmoles
reviewed
Sep 4, 2020
README.md
Outdated
| @@ -352,7 +352,7 @@ See [azure_virtual_machine](libraries/azure_virtual_machine.rb) for a standard s | |||
| - If the properties of the resource are to be manipulated before populating the FilterTable, a `populate_table` method has to be defined. See [azure_virtual_machines](libraries/azure_virtual_machines.rb). | |||
| - If the resources exist in another resource, such as subnets of a virtual network, a `resource_path` has to be created. | |||
| For that, the identifiers of the parent resource, `resource_group` and virtual network name `vnet`, must be required from the users. | |||
| See [azure_subnets](libraries/azure_subnets.rb). | |||
| See [azure_subnet](libraries/azure_subnets.rb). | |||
There was a problem hiding this comment.
this looked correct before 🤔
rmoles
reviewed
Sep 4, 2020
docs/resources/azure_iothub.md
Outdated
| @@ -26,7 +26,7 @@ For an example `inspec.yml` file and how to set up your Azure credentials, refer | |||
|
|
|||
| ## Syntax | |||
|
|
|||
| The `resource_group` and `name` must be given as a parameter. | |||
| The `resource_group` and `name` or the `resource_id` must be given as a parameter. | |||
There was a problem hiding this comment.
nitpick, The is present here but not in most others
rmoles
reviewed
Sep 4, 2020
| @@ -26,7 +26,7 @@ For an example `inspec.yml` file and how to set up your Azure credentials, refer | |||
|
|
|||
| ## Syntax | |||
|
|
|||
| The `resource_group`, `resource_name`, `event_hub_endpoint` and `name` must be given as a parameter. | |||
| The `resource_group`, `resource_name`, `event_hub_endpoint` and `name` or the `resource_id` must be given as a parameter. | |||
There was a problem hiding this comment.
same as the previous comment
added 2 commits
September 4, 2020 17:08
Signed-off-by: Omer Demirok <odemirok@chef.io>
Signed-off-by: Omer Demirok <odemirok@chef.io>
rmoles
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Omer Demirok odemirok@chef.io
Description
README
OLD DOCS
NEW DOCS
BACKEND
AzurermAdUsersclass.Issues Resolved
N/A
Check List
rake lintpasses