Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve resource not found #291

Merged
merged 5 commits into from
Sep 8, 2020
Merged

Conversation

omerdemirok
Copy link
Contributor

Signed-off-by: Omer Demirok odemirok@chef.io

Description

  • Improve resource not found.
  • Differentiate resource failure between singular and plural resources when resources not found.
  • Support resource_path parameter in the singular generic resource.

Issues Resolved

When resource_group is not found, resources will return false to exist? instead of failing the resource.

Check List

Omer Demirok added 3 commits September 7, 2020 18:14

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Omer Demirok <odemirok@chef.io>
Signed-off-by: Omer Demirok <odemirok@chef.io>
Signed-off-by: Omer Demirok <odemirok@chef.io>
@omerdemirok omerdemirok requested a review from a team as a code owner September 8, 2020 07:34
Copy link

@skpaterson skpaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks @omerdemirok

@skpaterson skpaterson added the Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. label Sep 8, 2020
@skpaterson skpaterson merged commit 3416190 into master Sep 8, 2020
@skpaterson skpaterson deleted the fix_resource_group_not_found branch September 8, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants