Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Policy Definition and Resource Group Resources #301

Merged
merged 7 commits into from
Sep 23, 2020
Merged

Add Policy Definition and Resource Group Resources #301

merged 7 commits into from
Sep 23, 2020

Conversation

omerdemirok
Copy link
Contributor

Signed-off-by: Omer Demirok odemirok@chef.io

Description

New resources:

  • azure_policy_definition(s)
  • azure_resourc_group

Re-write

  • azure_resourc_groupr

Docs

  • Add new ones for the new resources.
  • Update a URL in the existing docs.

Please note that this PR requires this to be merged first.

Issues Resolved

Resolves #297

Check List

Add azure_policy_definition(s) and azure_resource_group
942ca13 
Signed-off-by: Omer Demirok <odemirok@chef.io>
@omerdemirok omerdemirok added the Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. label Sep 22, 2020
@omerdemirok omerdemirok requested a review from a team as a code owner September 22, 2020 16:26
rmoles
rmoles reviewed Sep 23, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
Omer Demirok added 2 commits September 23, 2020 11:33
Update readme
6034eee 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Merge branch 'resource_group_policy_definition' of github.com:inspec/…
b3e6ef2 
…inspec-azure into resource_group_policy_definition
Tidy up docs
56dad4c 
Signed-off-by: Omer Demirok <odemirok@chef.io>
@omerdemirok omerdemirok force-pushed the resource_group_policy_definition branch from f695a33 to 56dad4c Compare September 23, 2020 12:09
Omer Demirok added 2 commits September 23, 2020 13:21
rmoles
rmoles approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@rmoles rmoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @omerdemirok. This looks good to me.

@rmoles rmoles merged commit b2dc586 into master Sep 23, 2020
@rmoles rmoles deleted the resource_group_policy_definition branch September 23, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmoles rmoles rmoles approved these changes

Assignees
No one assigned
Labels
Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to Test Azure Policy Definitions
2 participants
@omerdemirok @rmoles