Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resource_provider issue in generic_resource #303

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Fix resource_provider issue in generic_resource #303

merged 1 commit into from
Sep 24, 2020

Conversation

omerdemirok
Copy link
Contributor

Signed-off-by: Omer Demirok odemirok@chef.io

Description

azure_generic_resource is not functioning as intended when the resource_provider parameter is used.

Issues Resolved

Fixes #302

Check List

Fix resource_provider issue in generic_resource
9bc5562 
Signed-off-by: Omer Demirok <odemirok@chef.io>
@omerdemirok omerdemirok requested a review from a team as a code owner September 23, 2020 15:57
rmoles
rmoles approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@rmoles rmoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @omerdemirok

rachelrice
rachelrice approved these changes Sep 24, 2020
View reviewed changes
Copy link

@rachelrice rachelrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rachelrice rachelrice merged commit d79a0b6 into master Sep 24, 2020
@rachelrice rachelrice deleted the fix_generic_resource branch September 24, 2020 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmoles rmoles rmoles approved these changes

@rachelrice rachelrice rachelrice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

azure_generic_resource does not work with the resource_provider: set to 'Microsoft.Web/sites'
3 participants
@omerdemirok @rachelrice @rmoles