Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add security center policy resources #311

Merged
merged 5 commits into from
Oct 2, 2020
Merged

Add security center policy resources #311

merged 5 commits into from
Oct 2, 2020

Conversation

omerdemirok
Copy link
Contributor

Signed-off-by: Omer Demirok odemirok@chef.io

Description

ADD

  • Add azure_security_center_policy and azure_security_center_policies resources

UPDATE

  • Make validate_resource_uri method accept parameters and return result to be able to use it in additional API calls
  • Improve some error messages
  • Make resource type comparison case insensitive in get_api_version method

Issues Resolved

N/A

Check List

Add security_center_policiy(ies)
51fa9dd 
Signed-off-by: Omer Demirok <odemirok@chef.io>
@omerdemirok omerdemirok requested a review from a team as a code owner September 30, 2020 16:11
Omer Demirok added 2 commits October 1, 2020 10:56
Make resources accept common parameters (api_version, http_client, cl…
7699ae1 
…oud)

Signed-off-by: Omer Demirok <odemirok@chef.io>
Fix azure_resource_groups#to_s method
a857bdb 
Signed-off-by: Omer Demirok <odemirok@chef.io>
@rmoles rmoles changed the title Add security center policiy resources Add security center policy resources Oct 1, 2020
rmoles
rmoles reviewed Oct 1, 2020
View reviewed changes
libraries/azure_backend.rb Outdated Show resolved Hide resolved
Omer Demirok added 2 commits October 1, 2020 15:53
Merge branch 'master' into security_policy
a058ce1
Fix a typo in docs
d870c78 
Signed-off-by: Omer Demirok <odemirok@chef.io>
rmoles
rmoles approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@rmoles rmoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @omerdemirok

@rmoles rmoles merged commit da55752 into master Oct 2, 2020
@rmoles rmoles deleted the security_policy branch October 2, 2020 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmoles rmoles rmoles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omerdemirok @rmoles