Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support "$filter" parameter in plural generic resources #323

Merged
merged 2 commits into from
Oct 21, 2020
Merged

Support "$filter" parameter in plural generic resources #323

merged 2 commits into from
Oct 21, 2020

Conversation

omerdemirok
Copy link
Contributor

@omerdemirok omerdemirok commented Oct 15, 2020 •
edited
Loading

Signed-off-by: Omer Demirok odemirok@chef.io

Description

  • Support $filter parameter in plural generic resources and #additional_resource_properties method of singular resources

Issues Resolved

N/A

Check List

@omerdemirok omerdemirok requested a review from a team as a code owner October 15, 2020 15:20
Support "$filter" parameter in plural generic resources
1bd2158 
Signed-off-by: Omer Demirok <odemirok@chef.io>
@srb3 srb3 mentioned this pull request Oct 20, 2020
Merged
rmoles
rmoles approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@rmoles rmoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thanks @omerdemirok

@rmoles rmoles merged commit 84b4db4 into master Oct 21, 2020
@rmoles rmoles deleted the filter_free_text branch October 21, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmoles rmoles rmoles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omerdemirok @rmoles