Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding resource and docs for VPN gateways #331

Merged
merged 4 commits into from
Nov 12, 2020
Merged

Adding resource and docs for VPN gateways #331

merged 4 commits into from
Nov 12, 2020

Conversation

voojoe
Copy link
Contributor

@voojoe voojoe commented Nov 11, 2020

Signed-off-by: Joe McCrea joe.mccrea@sap.com

Description

Adding in resources and documentation for Azure VPN Gateways

Issues Resolved

#330

Check List

Signed-off-by: Joe McCrea <joe.mccrea@sap.com>
@voojoe voojoe requested a review from a team as a code owner November 11, 2020 16:35
Signed-off-by: Joe McCrea <joe.mccrea@sap.com>
@omerdemirok omerdemirok added the Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. label Nov 11, 2020
Copy link
Contributor

@omerdemirok omerdemirok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @voojoe!
Do you consider changing the name of the resource to azure_virtual_network_gateways? This will align better with the official Azure resource name here.

Copy link
Contributor

@omerdemirok omerdemirok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resource should be added to the project README.

Signed-off-by: Joe McCrea <joe.mccrea@sap.com>
@voojoe
Copy link
Contributor Author

voojoe commented Nov 11, 2020

Thanks for this @voojoe!
Do you consider changing the name of the resource to azure_virtual_network_gateways? This will align better with the official Azure resource name here.

Hi Omer, I've renamed this now in my latest commit.

Copy link
Contributor

@omerdemirok omerdemirok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this excellent contribution @voojoe!!
It is a milestone for being the first community resource with the new backend.

@omerdemirok omerdemirok merged commit 0e13839 into inspec:master Nov 12, 2020
@voojoe voojoe deleted the adding_azure_vpn_gateways branch November 25, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants