Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dataset test display #125

Closed
katie-murphy-ck opened this issue Mar 15, 2019 · 3 comments · Fixed by #127
Closed

Fix dataset test display #125

katie-murphy-ck opened this issue Mar 15, 2019 · 3 comments · Fixed by #127

Comments

@katie-murphy-ck
Copy link

katie-murphy-ck commented Mar 15, 2019

When running tests against a BQ dataset, rather than a pretty display in the test like "Firewall Rule my_tag_name", it just gives some internal address/name.
To reproduce: run a valid test against a dataset. Here's my example that gave me this issue (to be clear, the test results were all valid).

control 'no-public-datasets' do
  impact 1.0
  title 'public-bq-datasets-check'
  google_bigquery_datasets(project: gcp_project_id).dataset_references.each do |dataset_ref|
    google_bigquery_dataset(project: gcp_project_id, name: dataset_ref.dataset_id).access.each do |dataset_access|
      describe dataset_access do
        its('special_group') { should_not cmp 'allUsers' }
        its('special_group') { should_not cmp 'allAuthenticatedUsers' }
      end
    end
  end
end
@katie-murphy-ck
Copy link
Author

Attempted a fix in PR 123 #123

@slevenick
Copy link
Collaborator

Looking into a way to programmatically add to_s blocks with human readable descriptions to all MM generated objects and nested objects.

@slevenick
Copy link
Collaborator

This issue should be fixed with #127

@slevenick slevenick mentioned this issue Mar 18, 2019
skpaterson pushed a commit that referenced this issue Mar 20, 2019
Add test and alias for BigQuery Dataset name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants