-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support regional clusters #65
Comments
Thanks @matt-simons that makes good sense. PR's are always welcome! Otherwise will happily pick this up at the next opportunity. |
I've got something coded to support regional clusters. I'm new to both Inspec and Ruby, so I'd like to dogfood it a bit first. |
skpaterson
pushed a commit
that referenced
this issue
Jan 21, 2019
Update pubsub attributes to new external attribute system
Thanks @slevenick ! @pinterb I'll close this out but feel free to reopen if you encounter any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Presently
google_container_cluster
only supports zonal clusters as it uses theget_zone_cluster
function in https://github.com/googleapis/google-api-ruby-client/blob/master/generated/google/apis/container_v1beta1/service.rbIf instead it used
get_project_location_cluster
it would support both zonal and regional clusters.Similarly
google_container_clusters
could support both zonal and regional clusters if it usedlist_project_location_clusters
function.Happy to create a pull request to resolve this.
The text was updated successfully, but these errors were encountered: