Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support regional clusters #65

Closed
matt-simons opened this issue Oct 18, 2018 · 4 comments
Closed

Support regional clusters #65

matt-simons opened this issue Oct 18, 2018 · 4 comments

Comments

@matt-simons
Copy link

Presently google_container_cluster only supports zonal clusters as it uses the get_zone_cluster function in https://github.com/googleapis/google-api-ruby-client/blob/master/generated/google/apis/container_v1beta1/service.rb

If instead it used get_project_location_cluster it would support both zonal and regional clusters.

Similarly google_container_clusters could support both zonal and regional clusters if it used list_project_location_clusters function.

Happy to create a pull request to resolve this.

@skpaterson
Copy link

Thanks @matt-simons that makes good sense. PR's are always welcome! Otherwise will happily pick this up at the next opportunity.

@pinterb
Copy link

pinterb commented Nov 29, 2018

I've got something coded to support regional clusters. I'm new to both Inspec and Ruby, so I'd like to dogfood it a bit first.

skpaterson pushed a commit that referenced this issue Jan 21, 2019
Update pubsub attributes to new external attribute system
@skpaterson
Copy link

Thanks @slevenick ! @pinterb I'll close this out but feel free to reopen if you encounter any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants