Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google_compute_firewall: can't use allow_ssh? when the the rule is a DENY rule #73

Closed
walterdolce opened this issue Oct 31, 2018 · 1 comment
Closed

google_compute_firewall: can't use allow_ssh? when the the rule is a DENY rule #73

walterdolce opened this issue Oct 31, 2018 · 1 comment

Comments

@walterdolce
Copy link
Contributor

As per issue title, it seems it's not possible to use the helper when the rule is a DENY rule. The result I get is:

×  Firewall Rule deny-all-ssh allowed_ssh?
     google_compute_firewall is missing expected property 'allowed'
@skpaterson skpaterson mentioned this issue Nov 1, 2018
Merged
@skpaterson
Copy link

Indeed, the 'all' cases were left out initially, hopefully #76 should resolve that. Thanks for raising this @walterdolce.

skpaterson pushed a commit that referenced this issue Jan 24, 2019
@slevenick
Merge pull request #73 from modular-magician/codegen-pr-1262
73fe4eb 
Inspec autoscalers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@walterdolce @skpaterson