-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct names for nested object properties. #132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Modular Magician <magic-modules@google.com>
Inspec cloudfunction
Signed-off-by: Modular Magician <magic-modules@google.com>
Remove duplicated method due to merges
Signed-off-by: Modular Magician <magic-modules@google.com>
Adding support for backend buckets in InSpec
Signed-off-by: Modular Magician <magic-modules@google.com>
Adding support for backend buckets in InSpec
Signed-off-by: Modular Magician <magic-modules@google.com>
Use out_name instead of name for nested properties in markdown doc.
Signed-off-by: Sam Levenick <slevenick@google.com>
skpaterson
approved these changes
Mar 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @slevenick 👍
Signed-off-by: Modular Magician <magic-modules@google.com>
Refactor cloudfunction region variable
Signed-off-by: Modular Magician <magic-modules@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
Fix reference to variable in gcp-mm.tf
Signed-off-by: Sam Levenick <slevenick@google.com>
Add backend bucket signed URL key (for CDN) support
<!-- This change is generated by MagicModules. --> /cc @chrisst
Signed-off-by: Sam Levenick <slevenick@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
Signed-off-by: Sam Levenick <slevenick@google.com>
skpaterson
approved these changes
Apr 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks @slevenick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are currently showing up as camelCase, but are actually available as snake_case.
Included in f18b3f5