Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct names for nested object properties. #132

Merged
merged 24 commits into from
Apr 4, 2019

Conversation

slevenick
Copy link
Collaborator

They are currently showing up as camelCase, but are actually available as snake_case.

Included in f18b3f5

Signed-off-by: Modular Magician <magic-modules@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
Remove duplicated method due to merges
Signed-off-by: Modular Magician <magic-modules@google.com>
Adding support for backend buckets in InSpec
Signed-off-by: Modular Magician <magic-modules@google.com>
Adding support for backend buckets in InSpec
Signed-off-by: Modular Magician <magic-modules@google.com>
Use out_name instead of name for nested properties in markdown doc.
Signed-off-by: Sam Levenick <slevenick@google.com>
Copy link

@skpaterson skpaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @slevenick 👍

slevenick and others added 12 commits March 28, 2019 18:02
Signed-off-by: Modular Magician <magic-modules@google.com>
Refactor cloudfunction region variable
Signed-off-by: Modular Magician <magic-modules@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
Fix reference to variable in gcp-mm.tf
Signed-off-by: Sam Levenick <slevenick@google.com>
Add backend bucket signed URL key (for CDN) support
<!-- This change is generated by MagicModules. -->
/cc @chrisst
Signed-off-by: Sam Levenick <slevenick@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
Signed-off-by: Sam Levenick <slevenick@google.com>
Copy link

@skpaterson skpaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @slevenick

@skpaterson skpaterson merged commit 8dc211d into inspec:master Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants