Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appengine, ML engine, project IAM resources #178

Merged
merged 5 commits into from
Sep 16, 2019

Conversation

slevenick
Copy link
Collaborator

Description

Please describe what this change achieves. Ensure you have read the Contributing to InSpec GCP document before
submitting.

Adds new resources:
google_appengine_standard_app_version
google_ml_engine_model
google_resourcemanager_project_iam_policy

Modifies integration tests to remove some variables only used in a single place
Magic Modules generated updates to various resources

Issues Resolved

List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant.

Please ensure commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco

Experience Coder and others added 4 commits September 9, 2019 21:43
Signed-off-by: Modular Magician <magic-modules@google.com>
GCP Inspec for Standard Application Version
Signed-off-by: Modular Magician <magic-modules@google.com>
Add legacy_name to inspec, add ML model
@slevenick slevenick requested a review from a team as a code owner September 12, 2019 16:23
Copy link

@skpaterson skpaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @slevenick 👍

@skpaterson skpaterson added the Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. label Sep 16, 2019
@skpaterson skpaterson merged commit 29a116c into inspec:master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants