MM updates #280

slevenick · 2020-09-22T19:15:49Z

Description

Add network peerings, various MM updates

Issues Resolved

Please ensure commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco

Signed-off-by: Modular Magician <magic-modules@google.com>

* Fix check for serial port disabled * fix check for block-project-ssh-keys Signed-off-by: Modular Magician <magic-modules@google.com>

…416) * Add mode enum and scale down controls for Compute AutoScaler * Add mode enum for Compute AutoScaler in the correct API block * Add defaults for mode and default_from_api for scale down controls * Add tests for scale_down_controls and set at_least_one_of for it Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>

* change memcacheParameters to parameters, add parameters to basic test * make switching memcacheParameters to parameters not a breaking-change Signed-off-by: Modular Magician <magic-modules@google.com>

* add tiers and nfs_export_options * update docs, make full test beta Signed-off-by: Modular Magician <magic-modules@google.com>

* Add skip enum value generation * Fix default * Fix reader * Fix line spacing on enum values Signed-off-by: Modular Magician <magic-modules@google.com>

* Add ability to set global network endpoint group as backend for backend service. Make health_checks optional * PR fixes * Add encoder to remove max_utilization when neg backend * Check for global NEG in group to remove max_utilization * Add another nil check * Spacing * Docs fix Signed-off-by: Modular Magician <magic-modules@google.com>

* add firewall logging controls * make backward compatible * check enable_logging in expand * update docs * update expand logic to fix failing test Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Dana Hoffman <danahoffman@google.com> Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Dana Hoffman <danahoffman@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>

…429) * add source_image to google_compute_image * add source_snapshot to google_compute_image * PR comment changes Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>

* Add new field filter to pubsub. Fixes: hashicorp/terraform-provider-google#6727 * Fixed filter name, it was improperly set. * add filter key to pubsub subscription unit test * spaces not tabs! * hardcode filter value in test * revert remove escaped quotes Co-authored-by: Tim O'Connell <hi@timoconnell.co.uk> Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Tim O'Connell <hi@timoconnell.co.uk>

Signed-off-by: Modular Magician <magic-modules@google.com>

Add enableMessageOrdering to Pub/Sub Subscription Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: ialidzhikov <i.alidjikov@gmail.com> Signed-off-by: Modular Magician <magic-modules@google.com>

* use {product}.googleapis.com endpoints * use actual correct urls * fix zone data source test * fix network peering tests * possibly fix deleting default network Signed-off-by: Modular Magician <magic-modules@google.com>

…sion terraform resource (#3789) (#437) * add vpc access connector property in standard app version resource * add Gemfile.lock and .ruby-version * modify .ruby-version * Update Gemfile.lock * Update Gemfile.lock * Update Gemfile.lock * add test for vpcAccessConnector field * change casing of test field * add comma * format app engine connector test * make vpc_access_connector an object * add vpc access connector resource to test * pass connector id output property to app engine resource instead of hardcoding connector id Signed-off-by: Modular Magician <magic-modules@google.com>

* retrypolicy attribute added * test case updated Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>

…440) Co-authored-by: Dana Hoffman <danahoffman@google.com> Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Dana Hoffman <danahoffman@google.com>

Co-authored-by: Cameron Thornton <camthornton@google.com> Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Cameron Thornton <camthornton@google.com>

* added storage locations * add storage locations to field * tweak cmek logic * fix the decoder logic and cleanup whitespaces * remove duplicate entry Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>

…ol (#3973) (#445) Co-authored-by: Edward Sun <sunedward@google.com> Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Edward Sun <sunedward@google.com>

…(#3944) (#446) * added options & artifacts to cloudbuild trigger * updated with minor changes and added more options in test * a test adding update behavior for multiple optional fields Co-authored-by: Edward Sun <sunedward@google.com> Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Edward Sun <sunedward@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>

rmoles

Thanks @slevenick, just to let you know I am working through this PR.

rmoles · 2020-09-23T10:13:33Z

docs/resources/google_cloudbuild_trigger.md

+
+        * `object`: Google Cloud Storage object containing the source. This object must be a gzipped archive file (.tar.gz) containing source to build.
+
+        * `generation`: Google Cloud Storage generation for the object.  If the generation is omitted, the latest generation will be used


There's a bunch of instances of double-spacing throughout the resource documentation, this would probably need to be updated upstream though right?
It's not a huge issue at all though.

Suggest we proceed with what's here but you're right, the spacing could be tweaked in a future MM PR to ensure consistency.

Signed-off-by: Modular Magician <magic-modules@google.com>

skpaterson

LGTM, thanks @slevenick

modular-magician and others added 30 commits June 19, 2020 10:22

fix typo (#3369) (#413)

59d32bb

Signed-off-by: Modular Magician <magic-modules@google.com>

Fix check for serial port disabled (#3695) (#415)

6300d63

* Fix check for serial port disabled * fix check for block-project-ssh-keys Signed-off-by: Modular Magician <magic-modules@google.com>

added support for shielded nodes in container (#3639) (#417)

495a08f

Signed-off-by: Modular Magician <magic-modules@google.com>

fix memcache_parameters (#3733) (#418)

2eb472b

* change memcacheParameters to parameters, add parameters to basic test * make switching memcacheParameters to parameters not a breaking-change Signed-off-by: Modular Magician <magic-modules@google.com>

add tiers and nfs_export_options (#3766) (#419)

b9fd5a0

* add tiers and nfs_export_options * update docs, make full test beta Signed-off-by: Modular Magician <magic-modules@google.com>

Add skip enum value generation (#3767) (#420)

92356e2

* Add skip enum value generation * Fix default * Fix reader * Fix line spacing on enum values Signed-off-by: Modular Magician <magic-modules@google.com>

add firewall logging controls (#3780) (#422)

3a9f29a

* add firewall logging controls * make backward compatible * check enable_logging in expand * update docs * update expand logic to fix failing test Signed-off-by: Modular Magician <magic-modules@google.com>

Fix colon in doc notes (#3796) (#423)

932ef02

Signed-off-by: Modular Magician <magic-modules@google.com>

Add persistence_iam_identity to Redis Instance (#3805) (#424)

9ee8357

Signed-off-by: Modular Magician <magic-modules@google.com>

Org Security Policies (Hierarchical Firewalls) (#3626) (#425)

64ec4dc

Co-authored-by: Dana Hoffman <danahoffman@google.com> Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Dana Hoffman <danahoffman@google.com>

Adding Missing Cloud Build Attributes (#3627) (#426)

660eaf7

Signed-off-by: Modular Magician <magic-modules@google.com>

Add additional fields to Memcached Instance (#3821) (#427)

55b6655

Signed-off-by: Modular Magician <magic-modules@google.com>

Convert inboundServices to an enum. (#3820) (#428)

bd1fe66

Signed-off-by: Modular Magician <magic-modules@google.com>

add source_image and source_snapshot to google_compute_image (#3799) (#…

8baa33b

…429) * add source_image to google_compute_image * add source_snapshot to google_compute_image * PR comment changes Signed-off-by: Modular Magician <magic-modules@google.com>

Collection fixes for release (#3831) (#430)

a60496e

Signed-off-by: Modular Magician <magic-modules@google.com>

Add archive class to gcs (#3867) (#432)

b8772a7

Signed-off-by: Modular Magician <magic-modules@google.com>

Add support for gRPC healthchecks (#3825) (#433)

706f919

Signed-off-by: Modular Magician <magic-modules@google.com>

Add enableMessageOrdering to Pub/Sub Subscription (#3872) (#434)

5ae9667

Add enableMessageOrdering to Pub/Sub Subscription Signed-off-by: Modular Magician <magic-modules@google.com>

Specify possible values for arg only once (#3874) (#435)

8f497d6

Signed-off-by: ialidzhikov <i.alidjikov@gmail.com> Signed-off-by: Modular Magician <magic-modules@google.com>

use {product}.googleapis.com endpoints (#3755) (#436)

aef0355

* use {product}.googleapis.com endpoints * use actual correct urls * fix zone data source test * fix network peering tests * possibly fix deleting default network Signed-off-by: Modular Magician <magic-modules@google.com>

retrypolicy attribute added (#3843) (#438)

62c0823

* retrypolicy attribute added * test case updated Signed-off-by: Modular Magician <magic-modules@google.com>

add discovery endpoint (#3891) (#439)

4740dc9

Signed-off-by: Modular Magician <magic-modules@google.com>

Advanced logging config options in google_compute_subnetwork (#3603) (#…

a7532ad

…440) Co-authored-by: Dana Hoffman <danahoffman@google.com> Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Dana Hoffman <danahoffman@google.com>

Add Erase Windows VSS support to compute disk (#3898) (#441)

5e860a3

Co-authored-by: Cameron Thornton <camthornton@google.com> Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Cameron Thornton <camthornton@google.com>

Add Snapshot location to compute snapshot (#3896) (#442)

7173605

* added storage locations * add storage locations to field * tweak cmek logic * fix the decoder logic and cleanup whitespaces * remove duplicate entry Signed-off-by: Modular Magician <magic-modules@google.com>

Added missing 'all' option for protocol firewall rule (#3962) (#443)

054a8cd

Signed-off-by: Modular Magician <magic-modules@google.com>

modular-magician and others added 6 commits September 9, 2020 08:48

Revert eraseWindowsVssSignature field and test (#3959) (#444)

76663bb

Signed-off-by: Modular Magician <magic-modules@google.com>

Added support GRPC for google_compute_(region)_backend_service.protoc…

40c7ac9

…ol (#3973) (#445) Co-authored-by: Edward Sun <sunedward@google.com> Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Edward Sun <sunedward@google.com>

products/container: Add datapath provider field (#3956) (#447)

a5798d0

Signed-off-by: Modular Magician <magic-modules@google.com>

Add SEV_CAPABLE option to google_compute_image (#3994) (#448)

3edd18f

Signed-off-by: Modular Magician <magic-modules@google.com>

Add network peerings for inspec (#4002) (#449)

da36f4c

Signed-off-by: Modular Magician <magic-modules@google.com>

slevenick requested a review from a team as a code owner September 22, 2020 19:15

rmoles reviewed Sep 23, 2020

View reviewed changes

Update docs for pubsub targets in cloud scheduler (#4008) (#450)

37f3853

Signed-off-by: Modular Magician <magic-modules@google.com>

skpaterson approved these changes Sep 29, 2020

View reviewed changes

Merge branch 'master' into master

e08a6b8

skpaterson added the Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. label Sep 29, 2020

skpaterson merged commit 4b16e6b into inspec:master Sep 29, 2020

clintoncwolfe mentioned this pull request Feb 15, 2021

Expose network peers via google_compute_networks. #274

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MM updates #280

MM updates #280

slevenick commented Sep 22, 2020

rmoles left a comment

rmoles Sep 23, 2020 •

edited

Loading

skpaterson Sep 29, 2020

skpaterson left a comment


		* `object`: Google Cloud Storage object containing the source. This object must be a gzipped archive file (.tar.gz) containing source to build.

		* `generation`: Google Cloud Storage generation for the object. If the generation is omitted, the latest generation will be used

MM updates #280

MM updates #280

Conversation

slevenick commented Sep 22, 2020

Description

Issues Resolved

rmoles left a comment

Choose a reason for hiding this comment

rmoles Sep 23, 2020 • edited Loading

Choose a reason for hiding this comment

skpaterson Sep 29, 2020

Choose a reason for hiding this comment

skpaterson left a comment

Choose a reason for hiding this comment

rmoles Sep 23, 2020 •

edited

Loading