Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage updates #52

Merged
merged 4 commits into from
Sep 11, 2018
Merged

Storage updates #52

merged 4 commits into from
Sep 11, 2018

Conversation

skpaterson
Copy link

More details:

  • Added google_storage_bucket_objects resource
  • Reworked google_storage_bucket_acl and google_storage_default_object_acl to better cope with Not Found exceptions
  • Helper method for logging in google_storage_bucket

Stuart Paterson added 3 commits September 6, 2018 11:29
Signed-off-by: Stuart Paterson <spaterson@chef.io>
Signed-off-by: Stuart Paterson <spaterson@chef.io>
Signed-off-by: Stuart Paterson <spaterson@chef.io>
### Test that there are no more than a specified number of storage buckets for the project

describe google_storage_bucket_objects(bucket: 'bucket-name') do
its('count') { should be <= 100}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor, but the linting of Ruby would state that there should be a space between 100 and the }

Copy link
Contributor

@russellseymour russellseymour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Signed-off-by: Stuart Paterson <spaterson@chef.io>
@russellseymour russellseymour merged commit f58c106 into master Sep 11, 2018
@russellseymour russellseymour deleted the storage-updates branch September 11, 2018 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants