Pubsub subscription + topic #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Levenick <slevenick@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
… documentation Signed-off-by: Modular Magician <magic-modules@google.com>
Add InSpec disk resource, refactors of attributes within examples and documentation
Signed-off-by: Modular Magician <magic-modules@google.com>
Remove extra braces from inspec ssl policy test
Signed-off-by: jnahelou <nahelou.j@sfeir.com>
Signed-off-by: jnahelou <nahelou.j@sfeir.com>
Feat/pubsub magicmodule
Signed-off-by: Sam Levenick <slevenick@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
Add PubSub support
Signed-off-by: Sam Levenick <slevenick@google.com>
Signed-off-by: Sam Levenick <slevenick@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
slevenick
commented
Jan 16, 2019
| @@ -1,5 +1,6 @@ | |||
| --- | |||
| AllCops: | |||
| TargetRubyVersion: 2.4 | |||
There was a problem hiding this comment.
Added this to pin the ruby version rubocop was targeting. I was seeing errors in Travis due to default target ruby version that weren't showing up in my local environment and vice versa. I don't have an attachment to 2.4, just want something
skpaterson
approved these changes
Jan 21, 2019
skpaterson
pushed a commit
that referenced
this pull request
Mar 1, 2019
Add router support in InSpec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes jnahelou's work from #95 as well as a couple refactoring changes. Generated from MM