enabling default backend cache #264
Conversation
Signed-off-by: Pranay Singh <i5singh.pranay@gmail.com>
|
Hey, sorry this sat for so long without a review - the code change looks good, but there should be an update to the README.md as well, documenting the new setting. Once that's in and has been reviewed, this should be good to go! |
Signed-off-by: Pranay Singh <i5singh.pranay@gmail.com>
README.md
Outdated
| @@ -282,6 +282,8 @@ When using Input plugins, please be aware that input values get cached between s | |||
| cache_inputs: false | |||
| ``` | |||
|
|
|||
| Default for backend cache is enabled | |||
There was a problem hiding this comment.
Please give an example of setting the value. Imagine you are a user, wishing to disable the backend cache. What is the exact name of the setting? Where in the configuration tree does the setting go? Thanks!
Signed-off-by: Pranay Singh <i5singh.pranay@gmail.com>
README.md
Outdated
| @@ -282,7 +282,12 @@ When using Input plugins, please be aware that input values get cached between s | |||
| cache_inputs: false | |||
| ``` | |||
|
|
|||
| Default for backend cache is enabled | |||
| Backend cache is enabled by default,if you want to disable backend cache you can do: | |||
There was a problem hiding this comment.
Let's add a section header to clarify this is different than the input cache.
### Chef InSpec Backend Cache
Chef InSpec uses a cache when executing commands and accessing files on the remote target. The cache is enabled by default. To disable the cache:
Signed-off-by: Pranay Singh <i5singh.pranay@gmail.com>
clintoncwolfe
added
Expeditor: Bump Version Minor
|
II think caching the commands executions by default is not the right call and it is going to confuse people. This is the kind of change that someone would enable when looking to optimise the tests. Also all those that have been creating hundreds of projects without caching have now to review all of them making sure the test is still correct or change the kitchen.yaml |
|
Following on from #212 (comment), I do have a suggestion: the documentation should be improved to explain why you might need to disable the backend cache, such as the situation of retrying tests (while waiting for system services to start up), as explained in the linked comment. |
Signed-off-by: Pranay Singh i5singh.pranay@gmail.com
Description
kitchen-inspec the default for backend_cache is disabled so running test cases (against a windows 2016 instance) without cache enabled is taking more time than usual.
Adding backend_cache: true (enabled) will improve performance.
Issues Resolved
Check List