[actions] use node/install instead of node/run; use codecov action

inspect-js · May 8, 2021 · 304af52 · 304af52
1 parent b4f7636
commit 304af52
Show file tree

Hide file tree

Showing 5 changed files with 37 additions and 28 deletions.
diff --git a/.github/workflows/node-4+.yml b/.github/workflows/node-4+.yml
@@ -21,6 +21,7 @@ jobs:
     runs-on: ubuntu-latest
 
     strategy:
+      fail-fast: false
       matrix:
         node-version: ${{ fromJson(needs.matrix.outputs.latest) }}
         command:
@@ -29,11 +30,13 @@ jobs:
 
     steps:
       - uses: actions/checkout@v2
-      - uses: ljharb/actions/node/run@main
-        name: 'npm install && npm run ${{ matrix.command }}'
+      - uses: ljharb/actions/node/install@main
+        name: 'nvm install ${{ matrix.node-version }} && npm install'
         with:
           node-version: ${{ matrix.node-version }}
-          command: ${{ matrix.command }}
+      - run: npm run ${{ matrix.command }}
+      - uses: codecov/codecov-action@v1
+
   minors:
     needs: [matrix, latest]
     name: 'non-latest minors'
@@ -42,18 +45,20 @@ jobs:
     runs-on: ubuntu-latest
 
     strategy:
+      fail-fast: false
       matrix:
         node-version: ${{ fromJson(needs.matrix.outputs.minors) }}
         command:
           - 'tests-only'
 
     steps:
       - uses: actions/checkout@v2
-      - uses: ljharb/actions/node/run@main
-        name: 'npm install && npm run ${{ matrix.command }}'
+      - uses: ljharb/actions/node/install@main
+        name: 'nvm install ${{ matrix.node-version }} && npm install'
         with:
           node-version: ${{ matrix.node-version }}
-          command: ${{ matrix.command }}
+      - run: npm run ${{ matrix.command }}
+      - uses: codecov/codecov-action@v1
 
   node:
     name: 'node 4+'

diff --git a/.github/workflows/node-iojs.yml b/.github/workflows/node-iojs.yml
@@ -21,6 +21,7 @@ jobs:
     runs-on: ubuntu-latest
 
     strategy:
+      fail-fast: false
       matrix:
         node-version: ${{ fromJson(needs.matrix.outputs.latest) }}
         command:
@@ -30,12 +31,13 @@ jobs:
 
     steps:
       - uses: actions/checkout@v2
-      - uses: ljharb/actions/node/run@main
-        name: 'npm install && npm run ${{ matrix.command }}'
+      - uses: ljharb/actions/node/install@main
+        name: 'nvm install ${{ matrix.node-version }} && npm install'
         with:
           node-version: ${{ matrix.node-version }}
-          command: ${{ matrix.command }}
           skip-ls-check: true
+      - run: npm run ${{ matrix.command }}
+      - uses: codecov/codecov-action@v1
 
   minors:
     needs: [matrix, latest]
@@ -45,6 +47,7 @@ jobs:
     runs-on: ubuntu-latest
 
     strategy:
+      fail-fast: false
       matrix:
         node-version: ${{ fromJson(needs.matrix.outputs.minors) }}
         command:
@@ -54,12 +57,13 @@ jobs:
 
     steps:
       - uses: actions/checkout@v2
-      - uses: ljharb/actions/node/run@main
-        name: 'npm install && npm run ${{ matrix.command }}'
+      - uses: ljharb/actions/node/install@main
+        name: 'nvm install ${{ matrix.node-version }} && npm install'
         with:
           node-version: ${{ matrix.node-version }}
-          command: ${{ matrix.command }}
           skip-ls-check: true
+      - run: npm run ${{ matrix.command }}
+      - uses: codecov/codecov-action@v1
 
   node:
     name: 'io.js'

diff --git a/.github/workflows/node-pretest.yml b/.github/workflows/node-pretest.yml
@@ -8,19 +8,19 @@ jobs:
 
     steps:
       - uses: actions/checkout@v2
-      - uses: ljharb/actions/node/run@main
-        name: 'npm install && npm run pretest'
+      - uses: ljharb/actions/node/install@main
+        name: 'nvm install lts/* && npm install'
         with:
           node-version: 'lts/*'
-          command: 'pretest'
+      - run: npm run pretest
 
   posttest:
     runs-on: ubuntu-latest
 
     steps:
       - uses: actions/checkout@v2
-      - uses: ljharb/actions/node/run@main
-        name: 'npm install && npm run posttest'
+      - uses: ljharb/actions/node/install@main
+        name: 'nvm install lts/* && npm install'
         with:
           node-version: 'lts/*'
-          command: 'posttest'
+      - run: npm run posttest
diff --git a/.github/workflows/node-zero.yml b/.github/workflows/node-zero.yml
@@ -21,6 +21,7 @@ jobs:
     runs-on: ubuntu-latest
 
     strategy:
+      fail-fast: false
       matrix:
         node-version: ${{ fromJson(needs.matrix.outputs.stable) }}
         command:
@@ -30,13 +31,14 @@ jobs:
 
     steps:
       - uses: actions/checkout@v2
-      - uses: ljharb/actions/node/run@main
-        name: 'npm install && npm run ${{ matrix.command }}'
+      - uses: ljharb/actions/node/install@main
+        name: 'nvm install ${{ matrix.node-version }} && npm install'
         with:
           node-version: ${{ matrix.node-version }}
-          command: ${{ matrix.command }}
           cache-node-modules-key: node_modules-${{ github.workflow }}-${{ github.action }}-${{ github.run_id }}
           skip-ls-check: true
+      - run: npm run ${{ matrix.command }}
+      - uses: codecov/codecov-action@v1
 
   unstable:
     needs: [matrix, stable]
@@ -46,6 +48,7 @@ jobs:
     runs-on: ubuntu-latest
 
     strategy:
+      fail-fast: false
       matrix:
         node-version: ${{ fromJson(needs.matrix.outputs.unstable) }}
         command:
@@ -55,13 +58,14 @@ jobs:
 
     steps:
       - uses: actions/checkout@v2
-      - uses: ljharb/actions/node/run@main
-        name: 'npm install && npm run ${{ matrix.command }}'
+      - uses: ljharb/actions/node/install@main
+        name: 'nvm install ${{ matrix.node-version }} && npm install'
         with:
           node-version: ${{ matrix.node-version }}
-          command: ${{ matrix.command }}
           cache-node-modules-key: node_modules-${{ github.workflow }}-${{ github.action }}-${{ github.run_id }}
           skip-ls-check: true
+      - run: npm run ${{ matrix.command }}
+      - uses: codecov/codecov-action@v1
 
   node:
     name: 'node 0.x'

diff --git a/.nycrc b/.nycrc
@@ -2,10 +2,6 @@
 	"all": true,
 	"check-coverage": false,
 	"reporter": ["text-summary", "text", "html", "json"],
-	"lines": 86,
-	"statements": 85.93,
-	"functions": 82.43,
-	"branches": 76.06,
 	"exclude": [
 		"coverage",
 		"test"