-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Show Connection-Status, Show Agent Attributes, Filter By Properties and Attributes #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Some things that I noticed:
- In the "Service Name" filter, I can only select "All" or services with connection status CONNECTED
- The default value for the "Connection Status" filter is CONNECTED, could you change this to "All"
- It appears weird to me, that the root page leads directly to the connections. Could you add the path /connections also in the UI? So I can access the page e.g. via localhost:8080/connections
Quality Gate passedIssues Measures |
Thanks for the review @EddeCCC,
The memo "uniqueFilterValues" did not get updated, so basically the inital filterstate in ConnectionTable.tsx controlled the selection options. Now it works as expected. Also the Filter-Function, SonarQube wanted made issues, cause "Attributes"-Column is a little more complex then just a String.
That was with purpose. Ingrida wanted it like that.
You can also access the page via localhost:8080/connections. Also when you click onto the menu point "Connections" you´ll get redirected to /connections. The ConnectionsPage-Component is routed onto both routes ("/" and "/connections"). I think that is valid, cause I don´t know what else to put onto the main-route... Maybe a Dashboard in the future? |
Luckily everything in /shadcn/ can be ignored, so it´s not that much code...