Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Show Connection-Status, Show Agent Attributes, Filter By Properties and Attributes #14

Merged
merged 11 commits into from
Nov 18, 2024

Conversation

levinkerschberger
Copy link
Member

Luckily everything in /shadcn/ can be ignored, so it´s not that much code...

Copy link
Member

@EddeCCC EddeCCC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Some things that I noticed:

  • In the "Service Name" filter, I can only select "All" or services with connection status CONNECTED
  • The default value for the "Connection Status" filter is CONNECTED, could you change this to "All"
  • It appears weird to me, that the root page leads directly to the connections. Could you add the path /connections also in the UI? So I can access the page e.g. via localhost:8080/connections

frontend/src/lib/react-table-utils.ts Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Nov 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
1.0% Duplication on New Code

See analysis details on SonarQube Cloud

@levinkerschberger
Copy link
Member Author

Thanks for the review @EddeCCC,

"In the "Service Name" filter, I can only select "All" or services with connection status CONNECTED"
there was indeed a Bug.

The memo "uniqueFilterValues" did not get updated, so basically the inital filterstate in ConnectionTable.tsx controlled the selection options. Now it works as expected.

Also the Filter-Function, SonarQube wanted made issues, cause "Attributes"-Column is a little more complex then just a String.
Removed the sorting for any non-trivial Filters

"The default value for the "Connection Status" filter is CONNECTED"

That was with purpose. Ingrida wanted it like that.

"It appears weird to me, that the root page leads directly to the connections. Could you add the path /connections also in the UI? So I can access the page e.g. via localhost:8080/connections"

You can also access the page via localhost:8080/connections. Also when you click onto the menu point "Connections" you´ll get redirected to /connections. The ConnectionsPage-Component is routed onto both routes ("/" and "/connections"). I think that is valid, cause I don´t know what else to put onto the main-route... Maybe a Dashboard in the future?
An instand redirect to /connection is also not really intuitive and quite weird to implement with react-router v6.

@EddeCCC EddeCCC merged commit b094099 into main Nov 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants