Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Persist configuration in local Git repository #5

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Feature: Persist configuration in local Git repository #5

merged 3 commits into from
Oct 7, 2024

Conversation

binarycoded
Copy link
Contributor

No description provided.

@binarycoded binarycoded requested a review from EddeCCC September 27, 2024 08:24
EddeCCC
EddeCCC requested changes Sep 28, 2024
View reviewed changes
Copy link
Member

@EddeCCC EddeCCC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add java docs to the classes and methods?

May you also include the inspectit-config-server.configurations.local-path property into the README?

backend/src/main/java/rocks/inspectit/gepard/agentmanager/configuration/service/GitService.java Outdated Show resolved Hide resolved
backend/src/main/java/rocks/inspectit/gepard/agentmanager/configuration/service/GitService.java Outdated Show resolved Hide resolved
backend/src/main/java/rocks/inspectit/gepard/agentmanager/configuration/service/GitService.java Outdated Show resolved Hide resolved
backend/src/main/java/rocks/inspectit/gepard/agentmanager/configuration/service/GitService.java Outdated Show resolved Hide resolved
backend/src/main/java/rocks/inspectit/gepard/agentmanager/exception/FileNotFoundException.java Outdated Show resolved Hide resolved
backend/src/main/java/rocks/inspectit/gepard/agentmanager/configuration/service/GitService.java Outdated Show resolved Hide resolved
.../src/test/java/rocks/inspectit/gepard/agentmanager/configuration/service/GitServiceTest.java Show resolved Hide resolved
.../src/test/java/rocks/inspectit/gepard/agentmanager/configuration/service/GitServiceTest.java Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@binarycoded binarycoded requested a review from EddeCCC October 4, 2024 11:37
@binarycoded binarycoded merged commit e431c34 into main Oct 7, 2024
2 checks passed
@binarycoded binarycoded deleted the feature/vhvapm-546 branch October 7, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EddeCCC EddeCCC EddeCCC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@binarycoded @EddeCCC