Skip to content

feature: Write "regex:" in front of value to indicate, that this is a pattern. #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

levinkerschberger
Copy link
Member

Like in Grafana, the user has to explicitly tell that he want´s to use regex in his query.
Otherwise the parameter is treated like a normal string.

Example:

{
    "agent": {
         serviceName: "regex:.*-service"
    }
}

would match all services with -service in the end.

Copy link
Member

@EddeCCC EddeCCC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, I'd suggest to adapt the package structure a bit.

It kinda breaks the hierarchy by creating a new regex package outside of connection.service, all though regex is still only used here.
I guess currently it makes more sense to just move it somewhere into connection?

Copy link
Member

@EddeCCC EddeCCC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've forgotten to also move the test package :P

Copy link

@levinkerschberger levinkerschberger merged commit 24b4720 into main Oct 31, 2024
1 check passed
@levinkerschberger levinkerschberger deleted the hotfix/query-500-bad-regex branch November 6, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants