Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #18: feature: Add WebSecurity to EUM Server #17

Merged
merged 7 commits into from
Dec 16, 2022

Conversation

ClaudioWaldvogel
Copy link
Contributor

@ClaudioWaldvogel ClaudioWaldvogel commented Nov 23, 2022

Closes #18

This change is Reviewable

@heiko-holz heiko-holz changed the title feature: Added WebSecurity to EUM Server Closes #18: feature: Add WebSecurity to EUM Server Nov 24, 2022
Copy link
Contributor

@heiko-holz heiko-holz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 19 of 19 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ClaudioWaldvogel)


src/main/java/rocks/inspectit/oce/eum/server/configuration/model/security/authProvider/SimpleApiTokenAuthenticationProviderSettings.java line 43 at r1 (raw file):

    private String defaultFileName;

    private boolean createDefaultFileIfNotExists = true;

why do we need the boolean?
Wouldn't it be sufficient to check if defaultFileName is not empty?

As far as I can see, defaultFileName is only used in SimpleApiAuthenticationProvider#createDefaultTokenProviderFile.

What happens if defaultFileName is set but createDefaultFileIfNotExists=false?


src/main/java/rocks/inspectit/oce/eum/server/utils/DirectoryPoller.java line 68 at r1 (raw file):

     * Flag to indicate that we need to shutdown the used executor on destroy.
     */
    private boolean isDefaultExecutor = false;

Shouldn't it rather say
Flag to indicate that the {@link #defaultExecutor()} is executed, which needs to be shut down on destroy?


src/main/java/rocks/inspectit/oce/eum/server/utils/DirectoryPoller.java line 97 at r1 (raw file):

    public DirectoryPoller start() {
        pollingTask = executor.scheduleWithFixedDelay(this::pollChanges, frequencyInMillis, frequencyInMillis, TimeUnit.MILLISECONDS);

should we start with an initial delay of frequencyInMillis or start immediately?

Copy link
Member

@MariusBrill MariusBrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 19 files at r1, 2 of 6 files at r2, 1 of 6 files at r3, 6 of 6 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ClaudioWaldvogel)

Copy link
Member

@MariusBrill MariusBrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ClaudioWaldvogel)

MariusBrill
MariusBrill previously approved these changes Nov 24, 2022
Copy link
Member

@MariusBrill MariusBrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ClaudioWaldvogel)

Copy link
Contributor

@heiko-holz heiko-holz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ClaudioWaldvogel)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] - Add WebSecurity to the EUM server using simple API token security
3 participants