Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat 1398: Introduction of UI tests into the Configuration UI project #1458

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

PDuwe
Copy link

@PDuwe PDuwe commented May 31, 2022

closes #1398

Includes:

  • jest and testing library setup
  • sample tests of LoginView
  • workflow 'Run Jest'
  • fixing some lint-errors of existing files that caused the build to fail

This change is Reviewable

@PDuwe PDuwe force-pushed the feat/feature-1398 branch from 48abf11 to 0e064c0 Compare May 31, 2022 13:29
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #1458 (0e064c0) into master (4ae7a26) will increase coverage by 0.47%.
The diff coverage is n/a.

❗ Current head 0e064c0 differs from pull request most recent head df4171b. Consider uploading reports for the commit df4171b to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1458      +/-   ##
============================================
+ Coverage     78.64%   79.11%   +0.47%     
+ Complexity     2271     2228      -43     
============================================
  Files           232      232              
  Lines          7438     7252     -186     
  Branches        887      860      -27     
============================================
- Hits           5849     5737     -112     
+ Misses         1219     1158      -61     
+ Partials        370      357      -13     
Impacted Files Coverage Δ
...ctit/ocelot/core/opentelemetry/DynamicSampler.java 60.00% <0.00%> (-30.00%) ⬇️
...rocks/inspectit/ocelot/bootstrap/AgentManager.java 62.50% <0.00%> (-4.17%) ⬇️
...ectit/ocelot/core/command/AgentCommandService.java 68.29% <0.00%> (-2.44%) ⬇️
...trumentation/actions/bound/BoundGenericAction.java 83.33% <0.00%> (-2.38%) ⬇️
...ore/opentelemetry/OpenTelemetryControllerImpl.java 78.12% <0.00%> (-0.40%) ⬇️
...tation/config/MethodHookConfigurationResolver.java 95.65% <0.00%> (-0.38%) ⬇️
...n/config/InstrumentationConfigurationResolver.java 97.25% <0.00%> (-0.10%) ⬇️
...spectit/ocelot/commons/models/command/Command.java 100.00% <0.00%> (ø)
...rumentation/rules/InstrumentationRuleSettings.java 100.00% <0.00%> (ø)
.../actions/bound/ConstantOnlyBoundGenericAction.java
... and 20 more

Copy link
Member

@MariusBrill MariusBrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @PDuwe)


-- commits line 2 at r1:
The code for the tests looks good. We'll keep this PR open until we have added the HowTo for testing.

@PDuwe PDuwe force-pushed the feat/feature-1398 branch from 0e064c0 to 2854e7e Compare June 27, 2022 06:13
@PDuwe PDuwe changed the title feat 1398: Introduction of UI tests into the Configuration UI project DRAFT: feat 1398: Introduction of UI tests into the Configuration UI project Jun 27, 2022
@heiko-holz heiko-holz marked this pull request as draft June 27, 2022 08:17
@PDuwe PDuwe changed the title DRAFT: feat 1398: Introduction of UI tests into the Configuration UI project feat 1398: Introduction of UI tests into the Configuration UI project Jun 27, 2022
danipaniii
danipaniii previously approved these changes Oct 17, 2022
Copy link
Contributor

@danipaniii danipaniii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @PDuwe)

@danipaniii danipaniii closed this Oct 31, 2022
@danipaniii danipaniii reopened this Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduction of UI tests into the Configuration UI project
3 participants