Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server timing header #1617

Merged
merged 23 commits into from
Sep 21, 2023
Merged

Server timing header #1617

merged 23 commits into from
Sep 21, 2023

Conversation

EddeCCC
Copy link
Member

@EddeCCC EddeCCC commented Sep 4, 2023

Add new function getTraceContext() in InspectitContextImpl to extract the trace context and use it inside actions


This change is Reviewable

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #1617 (3694371) into master (fcaecd7) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is 80.87%.

@@            Coverage Diff            @@
##             master    #1617   +/-   ##
=========================================
  Coverage     78.34%   78.34%           
- Complexity     2495     2517   +22     
=========================================
  Files           256      257    +1     
  Lines          8177     8247   +70     
  Branches        977      983    +6     
=========================================
+ Hits           6406     6461   +55     
- Misses         1352     1360    +8     
- Partials        419      426    +7     
Files Changed Coverage
...tit/ocelot/bootstrap/context/noop/NoopContext.java 0.00%
...strap/correlation/noop/NoopLogTraceCorrelator.java 0.00%
...xporter/BrowserPropagationHttpExporterService.java 0.00%
...on/context/propagation/BrowserPropagationUtil.java 58.82%
.../instrumentation/context/InspectitContextImpl.java 88.24%
...celot/core/exporter/BrowserPropagationServlet.java 92.98%
...tion/browser/BrowserPropagationSessionStorage.java 100.00%
...nstrumentation/context/ContextPropagationUtil.java 100.00%
...n/hook/actions/span/ContinueOrStartSpanAction.java 100.00%

@EddeCCC EddeCCC requested a review from TitusLabs September 8, 2023 12:10
Copy link
Contributor

@TitusLabs TitusLabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 15 of 16 files at r2, all commit messages.
Reviewable status: 15 of 16 files reviewed, 1 unresolved discussion (waiting on @EddeCCC)


inspectit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/instrumentation/hook/actions/span/ContinueOrStartSpanAction.java line 180 at r2 (raw file):

        }
        if (name == null) {
            if(methodInfo != null)

these can be combined


if(inspectitConfig == null) return;
int sessionLimit = inspectitConfig.getExporters().getTags().getHttp().getSessionLimit();
sessionStorage.setSessionLimit(sessionLimit);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates of exporter properties will restart the exporter. Thus, no updates have to be done in the scheduled method.

@EddeCCC
Copy link
Member Author

EddeCCC commented Sep 18, 2023

  • add createRemoteParentContext()
  • Patch Tags HTTP-Exporter
  • add session_id_header-property
  • update dependencies

Copy link
Member Author

@EddeCCC EddeCCC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 14 of 29 files reviewed, 2 unresolved discussions (waiting on @TitusLabs)


inspectit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/instrumentation/hook/actions/span/ContinueOrStartSpanAction.java line 180 at r2 (raw file):

Previously, TitusLabs (Titus Meyer) wrote…

these can be combined

Done.

Copy link
Contributor

@TitusLabs TitusLabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 15 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @EddeCCC)


inspectit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/exporter/BrowserPropagationServlet.java line 0 at r4 (raw file):
Where's the check for allowed origins?

Copy link
Member Author

@EddeCCC EddeCCC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 23 of 29 files reviewed, 2 unresolved discussions (waiting on @TitusLabs)


inspectit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/exporter/BrowserPropagationServlet.java line at r4 (raw file):

Previously, TitusLabs (Titus Meyer) wrote…

Where's the check for allowed origins?

Done.

Copy link
Contributor

@TitusLabs TitusLabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

@EddeCCC EddeCCC merged commit 7d2a17d into master Sep 21, 2023
12 checks passed
@EddeCCC EddeCCC deleted the server-timing-header branch October 31, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants