Vhvapm 444 #1653
Closed
Vhvapm 444 #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EddeCCC
requested changes
Apr 15, 2024
...ctit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/metrics/MeasureTagValueGuard.java
Show resolved
Hide resolved
...e/src/main/java/rocks/inspectit/ocelot/core/metrics/tagGuards/PersistedTagsReaderWriter.java
Outdated
Show resolved
Hide resolved
...c/test/java/rocks/inspectit/ocelot/core/metrics/tagGuards/PersistedTagsReaderWriterTest.java
Outdated
Show resolved
Hide resolved
...ctit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/metrics/MeasureTagValueGuard.java
Outdated
Show resolved
Hide resolved
...c/test/java/rocks/inspectit/ocelot/core/metrics/tagGuards/PersistedTagsReaderWriterTest.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/rocks/inspectit/ocelot/core/metrics/tagGuards/PersistedTagsReaderWriter.java
Outdated
Show resolved
Hide resolved
added 2 commits
April 18, 2024 09:48
… and fix the logic, using reader and writer instead of bytes
EddeCCC
requested changes
Apr 19, 2024
...ctit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/metrics/MeasureTagValueGuard.java
Outdated
Show resolved
Hide resolved
...ctit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/metrics/MeasureTagValueGuard.java
Outdated
Show resolved
Hide resolved
...ctit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/metrics/MeasureTagValueGuard.java
Outdated
Show resolved
Hide resolved
TimoF91
requested changes
May 8, 2024
EddeCCC
requested changes
May 22, 2024
Comment on lines
+207
to
+211
| TagGuardSettings tagGuardSettings = env.getCurrentConfig().getMetrics().getTagGuard(); | ||
| if (!tagGuardSettings.isEnabled()) { | ||
| log.error("Filename is not set. Not able to be writing tags."); | ||
| return null; | ||
| } |
There was a problem hiding this comment.
Das wird bereits vor getFilename() in isNotWritable() geprüft. Kann raus.
|
Merged in #1656 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is