Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add leads 3 support #30

Merged
merged 11 commits into from
Apr 2, 2024
Merged

Add leads 3 support #30

merged 11 commits into from
Apr 2, 2024

Conversation

koertho
Copy link
Contributor

@koertho koertho commented Jan 1, 2024

This PR adds support for leads 3.

Since Leads 3 do not offer the storeLeadsData hook, I needed to use the processFormData hook, where I load the corresponding leads data set. I also needed to adjust some code to make it compatible with haste 5 and changed database field names. The code should be compatible with haste 4+5 and lead 1+3.

src/ContaoManager/Plugin.php Outdated Show resolved Hide resolved
@fritzmg
Copy link
Contributor

fritzmg commented Mar 10, 2024

Me and @aschempp floated a different idea a while back. iirc it might make more sense to store the duplicates serialized into the respective fields. So if you have a field called name in your form which can be duplicated, you won't have name, name_2, name_3etc. - but rather you will havenamewith the valueName 1,Name 2,Name 3`.

@koertho wdyt?

Although I don't know how it should handle checkboxes (not sure how it is handled now).

@koertho
Copy link
Contributor Author

koertho commented Mar 11, 2024

The current way is better for my case, if I understand correctly, since I store first and last names and keeping them together makes more sense :)

@fritzmg fritzmg merged commit 84a1da8 into inspiredminds:master Apr 2, 2024
@fritzmg
Copy link
Contributor

fritzmg commented Apr 2, 2024

Thank you @koertho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants