Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assets: truncation at random (?) point #1642

Closed
2 tasks done
jacquerie opened this issue Oct 12, 2016 · 5 comments
Closed
2 tasks done

assets: truncation at random (?) point #1642

jacquerie opened this issue Oct 12, 2016 · 5 comments

Comments

@jacquerie
Copy link
Contributor

jacquerie commented Oct 12, 2016

http://inspire-nightly.cern.ch/ currently looks pretty bad:

assets-bug

This is due to the infamous truncation bug we've been intermittently seeing on our development machines. It could be related to this other truncation bug: miracle2k/webassets#468. The only issue with this theory is that the file currently served is 51288 bytes, but this could be the effect of the clean_css filter run afterwards.

  • Remove the clean_css filter and confirm that the truncation happens at 65536 bytes.
  • Work around the issue by pinning the known functioning version of node-sass when installing.
@jacquerie
Copy link
Contributor Author

jacquerie commented Oct 12, 2016

this could be the effect of the clean_css filter run afterwards

This is actually the case: the file currently served after removing the clean_css filter is exactly 65536 bytes.

@zzacharo
Copy link
Contributor

@jacquerie If this is the same problem that i dealt with when i installed inspirehep, i just ran npm install node-sass@3.4.2.

@jmartinm
Copy link
Contributor

@zzacharo for the moment it would be enough if you can update the documentation to specify the node-sass version needed.

@jacquerie
Copy link
Contributor Author

it would be enough if you can update the documentation to specify the node-sass version needed.

Sadly not :(

The fact is, docker-compose -f docker-compose.deps.yml run --rm assets will install things inside of the web container, which will fetch its own version of node-sass (currently 3.10.1). If we try to add node-sass@3.4.2 to the css bundle in inspirehep/modules/theme/bundles.py then we get an ELIFECYCLE error: sass/node-sass#1687 (comment)

@jacquerie
Copy link
Contributor Author

This is also blocking #1607.

rikirenz pushed a commit to rikirenz/inspire-next that referenced this issue Nov 14, 2016
* More recent versions of `node-sass` cause issue inspirehep#1642, therefore
  recommend developers to use this particular version (closes inspirehep#1644).

Signed-off-by: Zacharias Zacharodimos <zacharias.zacharodimos@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants