Feat : MultiCVRP wrapper #1043
Closed
Feat : MultiCVRP wrapper #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feat--multiCVRP-wrapper
Louay-Ben-nessir
requested review from
arnupretorius,
DriesSmit,
RuanJohn,
jcformanek,
siddarthsingh1,
sash-a,
OmaymaMahjoub,
ulricharmel,
callumtilbury and
WiemKhlifi
as code owners
sash-a
requested changes
Feb 28, 2024
sash-a
reviewed
Mar 4, 2024
sash-a
previously approved these changes
Mar 12, 2024
RuanJohn
reviewed
Mar 15, 2024
RuanJohn
requested changes
Mar 15, 2024
There was a problem hiding this comment.
Thank you @Louay-Ben-nessir! 🔥 Just a few question and suggestions from my side.
sash-a
previously approved these changes
Mar 18, 2024
WiemKhlifi
requested changes
Mar 19, 2024
WiemKhlifi
requested changes
Mar 21, 2024
…n-nessir/Mava into feat--multiCVRP-wrapper
mava/wrappers/jumanji.py
Outdated
|
|
||
| def __init__(self, env: MultiCVRP, add_global_state: bool = False): | ||
| env.num_agents = env._num_vehicles | ||
| env.time_limit = env._num_customers + 1 # added for consistency |
There was a problem hiding this comment.
Since I'm not very familiar with MultiCVRP 😅, I wanted to ask if the time_limit is only controlled in this way or if it can be set manually like in other environments?
There was a problem hiding this comment.
Jumanji's Multicvrp doesn't offer a way to manually set the time_limit. I changed it to None to better indicate this.
|
This PR has been closed as it requires extensive maintenance and testing before merging. Therefore, we have created an issue to track and address this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
adds a wrapper for multicvrp.
Why?
To make mulctivcrp mava compatible.
How?
This wrapper takes in the output from the multicvrp environment and converts it into a Mava suitable input.