Feat: unified gae #1129
Merged
Feat: unified gae #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonDuToit
requested review from
arnupretorius,
DriesSmit,
RuanJohn,
jcformanek,
siddarthsingh1,
sash-a,
OmaymaMahjoub,
ulricharmel and
WiemKhlifi
as code owners
sash-a
requested changes
Nov 7, 2024
sash-a
reviewed
Nov 8, 2024
Co-authored-by: Sasha Abramowitz <reallysasha@gmail.com>
OmaymaMahjoub
added
benchmark required
OmaymaMahjoub
requested changes
Nov 13, 2024
There was a problem hiding this comment.
@SimonDuToit if you can update MAT and Sable to use gae from this util file 🙏
OmaymaMahjoub
requested changes
Nov 22, 2024
There was a problem hiding this comment.
Thanks @SimonDuToit for the changes, just if you can fix the format and type issues that i mentioned 🙏
OmaymaMahjoub
previously approved these changes
Dec 3, 2024
sash-a
approved these changes
Dec 6, 2024
sash-a
added a commit
that referenced
this pull request
Jan 10, 2025
* unified gae * fixes * pre-commit * requested changes * Replace A with N (number of agents) Co-authored-by: Sasha Abramowitz <reallysasha@gmail.com> * same Co-authored-by: Sasha Abramowitz <reallysasha@gmail.com> * cleaning * undo mistake * more cleaning * merge conflicts * uncapitalize advantage comments --------- Co-authored-by: Sasha Abramowitz <reallysasha@gmail.com> Co-authored-by: Omayma Mahjoub <omaymamahjoub98@gmail.com>
sash-a
added a commit
that referenced
this pull request
Jan 10, 2025
* unified gae * fixes * pre-commit * requested changes * Replace A with N (number of agents) Co-authored-by: Sasha Abramowitz <reallysasha@gmail.com> * same Co-authored-by: Sasha Abramowitz <reallysasha@gmail.com> * cleaning * undo mistake * more cleaning * merge conflicts * uncapitalize advantage comments --------- Co-authored-by: Sasha Abramowitz <reallysasha@gmail.com> Co-authored-by: Omayma Mahjoub <omaymamahjoub98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes all PPO systems use a single shared function for calculating the GAE (#1118 ). This is made possible by making the feed forward systems use the dones from the previous step, bringing them in line with the recurrent systems.
Benchmark results: