feat: general wrapper framework #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Global state wrapper not yet working properly
sash-a
requested review from
arnupretorius,
DriesSmit,
RuanJohn,
jcformanek,
siddarthsingh1,
OmaymaMahjoub and
ulricharmel
as code owners
sash-a
commented
Nov 21, 2023
sash-a
commented
Nov 24, 2023
|
Just for bookkeeping #951 was discovered in this PR, but we're deciding to fix it in a separate PR so we can get this one in ASAP. |
OmaymaMahjoub
requested changes
Nov 27, 2023
|
I made all the necessary changes in this PR #952, just to make this PR smaller.
|
RuanJohn
requested changes
Nov 29, 2023
RuanJohn
reviewed
Nov 29, 2023
Merged
RuanJohn
approved these changes
Nov 30, 2023
OmaymaMahjoub
approved these changes
Nov 30, 2023
sash-a
pushed a commit
that referenced
this pull request
Dec 13, 2024
feat: general wrapper framework
sash-a
added a commit
that referenced
this pull request
Jan 10, 2025
- feat(shaed.py): move the shared wrappers in a seperate file - docs: small edits based on review - fix: small edits - revert: revert some changes + doc changing based on review - Merge new changes from develop into feat/general-wrapper-framework - revert: revert the changes made on done variable - feat: edit rec systems - feat: edit types and wrapper for other systems - Merge branch develop into feat/general-wrapper-framework - feat: repeat reward and discount in wrapper - fix: centralized critic eval bug with new wrapper - feat: general wrapper mostly complete Co-authored-by: Sasha Abramowitz <reallysasha@gmail.com> Co-authored-by: RuanJohn <33461981+RuanJohn@users.noreply.github.com>
sash-a
added a commit
that referenced
this pull request
Jan 10, 2025
- feat(shaed.py): move the shared wrappers in a seperate file - docs: small edits based on review - fix: small edits - revert: revert some changes + doc changing based on review - Merge new changes from develop into feat/general-wrapper-framework - revert: revert the changes made on done variable - feat: edit rec systems - feat: edit types and wrapper for other systems - Merge branch develop into feat/general-wrapper-framework - feat: repeat reward and discount in wrapper - fix: centralized critic eval bug with new wrapper - feat: general wrapper mostly complete Co-authored-by: Sasha Abramowitz <reallysasha@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
General observation and example rware wrapper which makes it easy to support more jumanji envs in the future 👀
Why?
To support more jumanji envs
How?
Create an observation type with known fields. Wrap all new envs so that they return this observation type instead of their own custom observation.